From: Liuwenyi <qingshenlwy@gmail.com>
To: Chris Mason <chris.mason@oracle.com>
Cc: Josef Bacik <josef@redhat.com>, strongzgy <strongzgy@gmail.com>,
onlyflyer <onlyflyer@gmail.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
ak <ak@linux.intel.com>, akpm <akpm@linux-foundation.org>,
miaox <miaox@cn.fujitsu.com>,
Yang Ruirui <ruirui.r.yang@tieto.com>,
meego-kernel <meego-kernel@meego.com>
Subject: Re: [PATCH] Avoid a NULL pointer in btrfs
Date: Thu, 20 Jan 2011 20:26:15 +0800 [thread overview]
Message-ID: <4D3829E7.9050305@gmail.com> (raw)
In-Reply-To: <1295452288-sup-8924@think>
=E4=BA=8E 2011-1-19 23:52, Chris Mason =E5=86=99=E9=81=93:
> Excerpts from Josef Bacik's message of 2011-01-19 09:14:02 -0500:
>> On Wed, Jan 19, 2011 at 10:08:13PM +0800, Liuwenyi wrote:
>>> In Yang Ruirui's mail, the btrfs will create a oops. This is caused=
by a
>>> null pointer in test_range_bit() while lock the spinlock.
>>>
>>> So, It is necessary to add a pointer check into test_range_bit()
>>>
>>
>> NAK, the tree shouldn't be null coming into this function, something=
else is
>> going wrong. What oops is this? Thanks,
The mail is here http://lkml.org/lkml/2011/1/19/24
another mesg is here http://www.aei.mpg.de/~crmafra/dmesg-2.6.35.3.txt
> What was your metadata blocksize for this oops? This call should nev=
er
> happen.
It is rare and hard to reproduced. So, I update this patch, just avoid =
a=20
null pointer calling.
> I think there is a larger problem, probably in the IO error handling
> code since the trace had io errors beforehand.
Yes, I agree. This situation is too strange to happen.
> -chris
---
Best Regards,
Liu Wenyi
prev parent reply other threads:[~2011-01-20 12:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 14:08 [PATCH] Avoid a NULL pointer in btrfs Liuwenyi
2011-01-19 14:14 ` Josef Bacik
2011-01-19 15:52 ` Chris Mason
2011-01-20 12:26 ` Liuwenyi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3829E7.9050305@gmail.com \
--to=qingshenlwy@gmail.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=meego-kernel@meego.com \
--cc=miaox@cn.fujitsu.com \
--cc=onlyflyer@gmail.com \
--cc=ruirui.r.yang@tieto.com \
--cc=strongzgy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).