linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Dan Rosenberg <drosenberg@vsecurity.com>
Cc: chris.mason@oracle.com, linux-btrfs@vger.kernel.org
Subject: Re: btrfs: issues with SUBVOL_SETFLAGS
Date: Thu, 10 Feb 2011 09:34:38 +0800	[thread overview]
Message-ID: <4D5340AE.6040602@cn.fujitsu.com> (raw)
In-Reply-To: <1297278881.11434.36.camel@Dan>

Dan Rosenberg wrote:
> Commit 0caa102da82799efaba88e234484786a9591c797 introduced the
> SUBVOL_SETFLAGS ioctl, which contains the following check:
> 
> 	if (flags & ~BTRFS_SUBVOL_CREATE_ASYNC)

Oops, should be:

if (flags & BTRFS_SUBVOL_CREATE_ASYNC)

> 		return -EINVAL;
> 
> 	if (flags & ~BTRFS_SUBVOL_RDONLY)
> 		return -EOPNOTSUPP;
> 
> Is it intentional that 0 is the only acceptable flags value?  In
> addition, there should probably be an inode ownership check before
> allowing setting subvolume flags.
> 

Thanks for pointing it out! Fix will be sent out soon.

      reply	other threads:[~2011-02-10  1:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-09 19:14 btrfs: issues with SUBVOL_SETFLAGS Dan Rosenberg
2011-02-10  1:34 ` Li Zefan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5340AE.6040602@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=chris.mason@oracle.com \
    --cc=drosenberg@vsecurity.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).