From: Miao Xie <miaox@cn.fujitsu.com>
To: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
Cc: Itaru Kitayama <kitayama@cl.bb4u.ne.jp>,
Chris Mason <chris.mason@oracle.com>,
David Sterba <dave@jikos.cz>,
Linux Btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH V3] btrfs: implement delayed inode items operation
Date: Mon, 07 Mar 2011 09:57:03 +0800 [thread overview]
Message-ID: <4D743B6F.2070708@cn.fujitsu.com> (raw)
In-Reply-To: <4D7417FB.2020205@jp.fujitsu.com>
On mon, 07 Mar 2011 08:25:47 +0900, Tsutomu Itoh wrote:
> (2011/03/05 16:01), Itaru Kitayama wrote:
>> Hi Miao,
>>
>> The V3 patch on top of the next-rc fails to pass an xfstests test 13.
>> In the btrfs link path, we need to reserve one more metadata in the
>> trans_block_rsv for the delayed inode update (if needed) to complete.
>
> Miao's patch (http://marc.info/?l=linux-btrfs&m=129802068318176&w=2)
> fixed this problem, maybe.
Yes, the above patch fixed this problem.
I think this problem is a bug of btrfs_link(), and hope the fix patch can
be received as early as possible. So I sent the above patch separately,
not with the delayed inode items operation patch.
Thanks
Miao
>
> Thanks,
> Itoh
>
>>
>> Here's the log from the test:
>>
>> ------------[ cut here ]------------
>> kernel BUG at fs/btrfs/delayed-inode.c:1565!
>> invalid opcode: 0000 [#2] PREEMPT SMP DEBUG_PAGEALLOC
>> last sysfs file: /sys/module/floppy/initstate
>> CPU 1
>> Modules linked in: nfsd exportfs nfs lockd fscache nfs_acl auth_rpcgss sunrpc ipv6 uinput snd_ens1371 gameport snd_rawmidi ]
>>
>> Pid: 6948, comm: fsstress Tainted: G D W 2.6.36-preempt+ #72 440BX Desktop Reference Platform/VMware Virtual Platform
>> RIP: 0010:[<ffffffff8120de65>] [<ffffffff8120de65>] btrfs_delayed_update_inode+0xfd/0x101
>> RSP: 0018:ffff88003b073d68 EFLAGS: 00010286
>> RAX: 00000000ffffffe4 RBX: ffff88002a876e48 RCX: ffff88004f3702a0
>> RDX: 00000000000003b9 RSI: 0000000000000001 RDI: ffff88003b072000
>> RBP: ffff88003b073da8 R08: 0000000000018000 R09: 0000000000000000
>> R10: ffff88004f3703f0 R11: 09f911029d74e35b R12: ffff88006861cb90
>> R13: ffff88002ec91c18 R14: 0000000000018000 R15: ffff88002a876ea0
>> FS: 00007fcad4905720(0000) GS:ffff880005000000(0000) knlGS:0000000000000000
>> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>> CR2: 00007f46eb380000 CR3: 00000000708b4000 CR4: 00000000000006e0
>> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
>> DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
>> Process fsstress (pid: 6948, threadinfo ffff88003b072000, task ffff88004f324710)
>> Stack:
>> ffff88003b073d88 ffff88004f3702a0 0000000000000000 ffff88002ec91c18
>> <0> ffff88006861cb90 ffff880036783c18 0000000000000000 ffff88006fcaf000
>> <0> ffff88003b073dc8 ffffffff811d8489 ffff88002ec91c18 ffff88006861cb90
>> Call Trace:
>> [<ffffffff811d8489>] btrfs_update_inode+0x17/0x44
>> [<ffffffff811da3e0>] btrfs_link+0xff/0x17a
>> [<ffffffff8112300d>] vfs_link+0xda/0x144
>> [<ffffffff811257ac>] sys_linkat+0xc4/0x121
>> [<ffffffff81118925>] ? fsnotify_modify+0x66/0x6e
>> [<ffffffff811190f8>] ? vfs_write+0xd2/0x10a
>> [<ffffffff81125827>] sys_link+0x1e/0x20
>> [<ffffffff81002ddb>] system_call_fastpath+0x16/0x1b
>> Code: f0 ff 40 60 eb 02 eb fe 4c 89 ff e8 7d 29 2b 00 31 f6 48 89 df e8 31 fb ff ff 31 c0 48 83 c4 18 5b 41 5c 41 5d 41 5e
>> RIP [<ffffffff8120de65>] btrfs_delayed_update_inode+0xfd/0x101
>> RSP <ffff88003b073d68>
>> ---[ end trace 38596ade53c80d11 ]---
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2011-03-07 1:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 6:06 [PATCH V3] btrfs: implement delayed inode items operation Miao Xie
2011-03-05 7:01 ` Itaru Kitayama
2011-03-06 23:25 ` Tsutomu Itoh
2011-03-07 1:57 ` Miao Xie [this message]
2011-03-10 3:07 ` Itaru Kitayama
2011-03-08 16:56 ` David Sterba
2011-03-09 5:40 ` Miao Xie
2011-03-11 15:24 ` David Sterba
-- strict thread matches above, loose matches on Subject: below --
2011-03-09 15:03 Itaru Kitayama
2011-03-10 6:21 ` Miao Xie
2011-03-16 9:48 ` Itaru Kitayama
2011-03-16 14:24 ` Miao Xie
2011-03-16 17:49 ` Chris Mason
2011-03-17 1:37 ` Itaru Kitayama
2011-03-18 3:37 ` Miao Xie
2011-03-18 8:59 ` Itaru Kitayama
2011-03-18 9:18 ` Miao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D743B6F.2070708@cn.fujitsu.com \
--to=miaox@cn.fujitsu.com \
--cc=chris.mason@oracle.com \
--cc=dave@jikos.cz \
--cc=kitayama@cl.bb4u.ne.jp \
--cc=linux-btrfs@vger.kernel.org \
--cc=t-itoh@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).