From: Arne Jansen <sensille@gmx.net>
To: linux-btrfs@vger.kernel.org, dave@jikos.cz
Subject: Re: [PATCH v2 3/6] btrfs: add scrub code and prototypes
Date: Wed, 23 Mar 2011 15:19:38 +0100 [thread overview]
Message-ID: <4D8A017A.6080705@gmx.net> (raw)
In-Reply-To: <20110322163812.GD17108@twin.jikos.cz>
On 22.03.2011 17:38, David Sterba wrote:
>> David Sterba wrote:
>>> On Fri, Mar 11, 2011 at 03:49:40PM +0100, Arne Jansen wrote:
>>>> This is the main scrub code.
>>>>
>>>
>>> sizeof(struct scrub_dev) == 18760 on an x86_64, an order 3 allocation in
>>> scrub_setup_dev()
>>
>> Is this a problem? There are only few allocations of it, one per device.
>
> High order allocations may fail when memory is fragmented, and should be
> avoided when possible. (And it is here, allocate each 'struct scrub_bio'
> separately and fill the bios array with pointers.) Scrub ioctl may fail
> to start until order-3 allocation will be available.
>
I updated this in my git repo.
Thanks,
Arne
next prev parent reply other threads:[~2011-03-23 14:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 14:49 [PATCH v2 0/6] btrfs: scrub Arne Jansen
2011-03-11 14:49 ` [PATCH v2 1/6] btrfs: add parameter to btrfs_lookup_csum_range Arne Jansen
2011-03-11 14:49 ` [PATCH v2 2/6] btrfs: make struct map_lookup public Arne Jansen
2011-03-11 14:49 ` [PATCH v2 3/6] btrfs: add scrub code and prototypes Arne Jansen
2011-03-11 16:34 ` David Sterba
2011-03-12 10:54 ` Arne Jansen
2011-03-22 16:38 ` David Sterba
2011-03-23 14:19 ` Arne Jansen [this message]
2011-03-11 14:49 ` [PATCH v2 4/6] btrfs: sync scrub with commit & device removal Arne Jansen
2011-03-11 14:49 ` [PATCH v2 5/6] btrfs: add state information for scrub Arne Jansen
2011-03-11 16:53 ` David Sterba
2011-03-12 13:13 ` Arne Jansen
2011-03-11 14:49 ` [PATCH v2 6/6] btrfs: new ioctls " Arne Jansen
2011-03-11 16:17 ` [PATCH v2 0/6] btrfs: scrub Ric Wheeler
2011-03-12 13:20 ` Arne Jansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8A017A.6080705@gmx.net \
--to=sensille@gmx.net \
--cc=dave@jikos.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).