From: liubo <liubo2009@cn.fujitsu.com>
To: Chris Mason <chris.mason@oracle.com>
Cc: Linux Btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: add initial tracepoint support for btrfs
Date: Tue, 29 Mar 2011 16:30:34 +0800 [thread overview]
Message-ID: <4D9198AA.5050909@cn.fujitsu.com> (raw)
In-Reply-To: <4D918E80.1010109@cn.fujitsu.com>
Please ignore this patch...
I just found we'd better revise the tracepoint side instead of btrfs side, will dig it more.
thanks,
liubo
> From: Liu Bo <liubo2009@cn.fujitsu.com>
>
> [PATCH] Btrfs: fix compile warnings of btrfs tracepoint on 32bit box
>
> include/trace/events/btrfs.h:47:1: warning: large integer implicitly truncated to unsigned type
> include/trace/events/btrfs.h:47:1: warning: large integer implicitly truncated to unsigned type
> include/trace/events/btrfs.h:47:1: warning: large integer implicitly truncated to unsigned type
>
> btrfs has defined some macros which value has ULL type, and when btrfs tracepoints
> use these macros on 32bit box, values like "-1ULL" will be truncated.
> This is where those warnings come from.
>
> Signed-off-by: Liu Bo <liubo2009@cn.fujitsu.com>
> ---
> include/trace/events/btrfs.h | 19 +++++++++++--------
> 1 files changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/include/trace/events/btrfs.h b/include/trace/events/btrfs.h
> index f445cff..27e67fd 100644
> --- a/include/trace/events/btrfs.h
> +++ b/include/trace/events/btrfs.h
> @@ -36,9 +36,12 @@ struct extent_buffer;
> { BTRFS_FS_TREE_OBJECTID, "FS_TREE" }, \
> { BTRFS_ROOT_TREE_DIR_OBJECTID, "ROOT_TREE_DIR" }, \
> { BTRFS_CSUM_TREE_OBJECTID, "CSUM_TREE" }, \
> - { BTRFS_TREE_LOG_OBJECTID, "TREE_LOG" }, \
> - { BTRFS_TREE_RELOC_OBJECTID, "TREE_RELOC" }, \
> - { BTRFS_DATA_RELOC_TREE_OBJECTID, "DATA_RELOC_TREE" })
> + { (unsigned long)BTRFS_TREE_LOG_OBJECTID, \
> + "TREE_LOG" }, \
> + { (unsigned long)BTRFS_TREE_RELOC_OBJECTID, \
> + "TREE_RELOC"}, \
> + { (unsigned long)BTRFS_DATA_RELOC_TREE_OBJECTID, \
> + "DATA_RELOC_TREE" })
>
> #define show_root_type(obj) \
> obj, ((obj >= BTRFS_DATA_RELOC_TREE_OBJECTID) || \
> @@ -126,13 +129,13 @@ DEFINE_EVENT(btrfs__inode, btrfs_inode_evict,
>
> #define __show_map_type(type) \
> __print_symbolic(type, \
> - { EXTENT_MAP_LAST_BYTE, "LAST_BYTE" }, \
> - { EXTENT_MAP_HOLE, "HOLE" }, \
> - { EXTENT_MAP_INLINE, "INLINE" }, \
> - { EXTENT_MAP_DELALLOC, "DELALLOC" })
> + { (unsigned long)EXTENT_MAP_LAST_BYTE, "LAST_BYTE" }, \
> + { (unsigned long)EXTENT_MAP_HOLE, "HOLE" }, \
> + { (unsigned long)EXTENT_MAP_INLINE, "INLINE" }, \
> + { (unsigned long)EXTENT_MAP_DELALLOC, "DELALLOC" })
>
> #define show_map_type(type) \
> - type, (type >= EXTENT_MAP_LAST_BYTE) ? "-" : __show_map_type(type)
> + type, (type >= EXTENT_MAP_LAST_BYTE) ? "-" : __show_map_type(type)
>
> #define show_map_flags(flag) \
> __print_flags(flag, "|", \
prev parent reply other threads:[~2011-03-29 8:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 11:18 [PATCH] Btrfs: add initial tracepoint support for btrfs liubo
2011-03-26 12:12 ` Chris Mason
2011-03-28 0:59 ` Chris Mason
2011-03-29 1:16 ` liubo
2011-03-29 7:47 ` liubo
2011-03-29 8:30 ` liubo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9198AA.5050909@cn.fujitsu.com \
--to=liubo2009@cn.fujitsu.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).