From: liubo <liubo2009@cn.fujitsu.com>
To: Linux Btrfs <linux-btrfs@vger.kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Chris Mason <chris.mason@oracle.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: [RFC PATCH] Trace: use unsigned long long in trace print frames
Date: Fri, 01 Apr 2011 14:42:35 +0800 [thread overview]
Message-ID: <4D9573DB.4010009@cn.fujitsu.com> (raw)
While adding tracepoint for btrfs, I got a problem:
btrfs uses some macros with "ULL" type, but tracepoint's macros,
__print_[flags,symbols](), only have "unsigned long", so on 32bit box
there will be 64->32 truncate WARNINGs when compiling.
Here I'm inclined to make the replacement to clear those WARNINGs.
Signed-off-by: Liu Bo <liubo2009@cn.fujitsu.com>
---
include/linux/ftrace_event.h | 7 ++++---
kernel/trace/trace_output.c | 10 +++++-----
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h
index 22b32af..b52f2c5 100644
--- a/include/linux/ftrace_event.h
+++ b/include/linux/ftrace_event.h
@@ -12,15 +12,16 @@ struct tracer;
struct dentry;
struct trace_print_flags {
- unsigned long mask;
+ unsigned long long mask;
const char *name;
};
const char *ftrace_print_flags_seq(struct trace_seq *p, const char *delim,
- unsigned long flags,
+ unsigned long long flags,
const struct trace_print_flags *flag_array);
-const char *ftrace_print_symbols_seq(struct trace_seq *p, unsigned long val,
+const char *ftrace_print_symbols_seq(struct trace_seq *p,
+ unsigned long long val,
const struct trace_print_flags *symbol_array);
const char *ftrace_print_hex_seq(struct trace_seq *p,
diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
index 456be90..97ba902 100644
--- a/kernel/trace/trace_output.c
+++ b/kernel/trace/trace_output.c
@@ -294,10 +294,10 @@ int trace_seq_path(struct trace_seq *s, struct path *path)
const char *
ftrace_print_flags_seq(struct trace_seq *p, const char *delim,
- unsigned long flags,
+ unsigned long long flags,
const struct trace_print_flags *flag_array)
{
- unsigned long mask;
+ unsigned long long mask;
const char *str;
const char *ret = p->buffer + p->len;
int i;
@@ -319,7 +319,7 @@ ftrace_print_flags_seq(struct trace_seq *p, const char *delim,
if (flags) {
if (p->len && delim)
trace_seq_puts(p, delim);
- trace_seq_printf(p, "0x%lx", flags);
+ trace_seq_printf(p, "0x%llx", flags);
}
trace_seq_putc(p, 0);
@@ -329,7 +329,7 @@ ftrace_print_flags_seq(struct trace_seq *p, const char *delim,
EXPORT_SYMBOL(ftrace_print_flags_seq);
const char *
-ftrace_print_symbols_seq(struct trace_seq *p, unsigned long val,
+ftrace_print_symbols_seq(struct trace_seq *p, unsigned long long val,
const struct trace_print_flags *symbol_array)
{
int i;
@@ -345,7 +345,7 @@ ftrace_print_symbols_seq(struct trace_seq *p, unsigned long val,
}
if (!p->len)
- trace_seq_printf(p, "0x%lx", val);
+ trace_seq_printf(p, "0x%llx", val);
trace_seq_putc(p, 0);
--
1.6.5.2
next reply other threads:[~2011-04-01 6:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 6:42 liubo [this message]
2011-04-01 13:49 ` [RFC PATCH] Trace: use unsigned long long in trace print frames Steven Rostedt
2011-04-02 1:41 ` liubo
2011-04-06 9:18 ` [PATCH] Trace: add __print_symbolic_u64 to avoid warnings on 32bit machine liubo
2011-04-15 16:24 ` Randy Dunlap
2011-04-15 16:37 ` Christoph Hellwig
2011-04-18 18:11 ` Steven Rostedt
2011-04-19 1:08 ` liubo
2011-04-19 1:35 ` [PATCH 1/2] tracing: " liubo
2011-04-29 10:01 ` liubo
2011-05-01 15:35 ` Steven Rostedt
2011-05-26 5:49 ` liubo
2011-05-25 12:27 ` Steven Rostedt
2011-05-25 16:12 ` Randy Dunlap
2011-05-25 16:47 ` Steven Rostedt
2011-05-25 16:50 ` Randy Dunlap
2011-05-26 1:08 ` Li Zefan
2011-05-26 1:17 ` Steven Rostedt
2011-04-19 1:35 ` [PATCH 2/2] tracing: update btrfs's tracepoints to use u64 interface liubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9573DB.4010009@cn.fujitsu.com \
--to=liubo2009@cn.fujitsu.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).