From: Li Zefan <lizf@cn.fujitsu.com>
To: "Zhong, Xin" <xin.zhong@intel.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH V2] Btrfs: fix subvolume mount by name problem when default mount subvolume is set
Date: Wed, 06 Apr 2011 14:34:02 +0800 [thread overview]
Message-ID: <4D9C095A.90400@cn.fujitsu.com> (raw)
In-Reply-To: <1302067633-20271-1-git-send-email-xin.zhong@intel.com>
13:27, Zhong, Xin wrote:
> We create two subvolumes (meego_root and meego_home) in
> btrfs root directory. And set meego_root as default mount
> subvolume. After we remount btrfs, meego_root is mounted
> to top directory by default. Then when we try to mount
> meego_home (subvol=meego_home) to a subdirectory, it failed.
> The problem is when default mount subvolume is set to
> meego_root, we search meego_home in meego_root but can not find
> it. So the solution is to add a new mount option (subvolrootid)
> to specify subvol id of root and search subvol name in it. For
> our case, now we can use "-o subvolrootid=0,subvol=meego_home)
> to mount meego_home.
>
> Detail information can be found in meego bugzilla:
> https://bugs.meego.com/show_bug.cgi?id=15055
>
> Signed-off-by: Zhong, Xin <xin.zhong@intel.com>
> ---
> fs/btrfs/super.c | 43 ++++++++++++++++++++++++++++++++++---------
> 1 files changed, 34 insertions(+), 9 deletions(-)
>
I guess you forgot to run checkpatch.pl.
ERROR: trailing whitespace
#183: FILE: fs/btrfs/super.c:807:
+^I^I$
ERROR: else should follow close brace '}'
#198: FILE: fs/btrfs/super.c:836:
}
+ else {
total: 2 errors, 0 warnings, 100 lines checked
next prev parent reply other threads:[~2011-04-06 6:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 5:27 [PATCH V2] Btrfs: fix subvolume mount by name problem when default mount subvolume is set Zhong, Xin
2011-04-06 6:34 ` Li Zefan [this message]
2011-04-06 8:10 ` Zhong, Xin
-- strict thread matches above, loose matches on Subject: below --
2011-04-06 7:13 Zhong, Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9C095A.90400@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=xin.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).