From: Josef Bacik <josef@redhat.com>
To: Chris Mason <chris.mason@oracle.com>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: if we've already started a trans handle, use that one
Date: Fri, 15 Apr 2011 14:12:20 -0400 [thread overview]
Message-ID: <4DA88A84.9080506@redhat.com> (raw)
In-Reply-To: <1302888971-sup-9684@think>
On 04/15/2011 01:36 PM, Chris Mason wrote:
> Excerpts from Josef Bacik's message of 2011-04-15 12:56:15 -0400:
>> We currently track trans handles in current->journal_info, but we don't actually
>> use it. This patch fixes it. This will cover the case where we have multiple
>> people starting transactions down the call chain. This keeps us from having to
>> allocate a new handle and all of that, we just increase the use count of the
>> current handle, save the old block_rsv, and return. I tested this with xfstests
>> and it worked out fine. Thanks,
>
> Just curious, which call stacks are currently nesting transactions?
>
The one that kept getting me in trouble was the run_delalloc_nocow which
could possibly call cow_file_range. I didn't notice any others, but I
didn't really look all that hard either. Thanks,
Josef
next prev parent reply other threads:[~2011-04-15 18:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 16:56 [PATCH] Btrfs: if we've already started a trans handle, use that one Josef Bacik
2011-04-15 17:36 ` Chris Mason
2011-04-15 18:12 ` Josef Bacik [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-04-13 19:17 Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA88A84.9080506@redhat.com \
--to=josef@redhat.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).