From: liubo <liubo2009@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linux Btrfs <linux-btrfs@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Chris Mason <chris.mason@oracle.com>
Subject: Re: [PATCH] Trace: add __print_symbolic_u64 to avoid warnings on 32bit machine
Date: Tue, 19 Apr 2011 09:08:21 +0800 [thread overview]
Message-ID: <4DACE085.9070202@cn.fujitsu.com> (raw)
In-Reply-To: <1303150309.7181.51.camel@gandalf.stny.rr.com>
On 04/19/2011 02:11 AM, Steven Rostedt wrote:
> On Wed, 2011-04-06 at 17:18 +0800, liubo wrote:
>> Btrfs has some "ULL" macros, and when these macros are passed to tracepoints'
>> __print_symbolic(), there will be 64->32 truncate WARNINGS during compiling
>> on 32bit box.
>>
>> Signed-off-by: Liu Bo <liubo2009@cn.fujitsu.com>
>> ---
>> include/linux/ftrace_event.h | 12 ++++++++++++
>> include/trace/events/btrfs.h | 4 ++--
>> include/trace/ftrace.h | 13 +++++++++++++
>> kernel/trace/trace_output.c | 27 +++++++++++++++++++++++++++
>> 4 files changed, 54 insertions(+), 2 deletions(-)
>
> Could you break this up into two patches. One that touches the ftrace
> core, and one that updates btrfs.
>
Sure, I'll break it and resend soon. Thanks for the reply.
thanks,
liubo
> Thanks,
>
> -- Steve
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2011-04-19 1:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 6:42 [RFC PATCH] Trace: use unsigned long long in trace print frames liubo
2011-04-01 13:49 ` Steven Rostedt
2011-04-02 1:41 ` liubo
2011-04-06 9:18 ` [PATCH] Trace: add __print_symbolic_u64 to avoid warnings on 32bit machine liubo
2011-04-15 16:24 ` Randy Dunlap
2011-04-15 16:37 ` Christoph Hellwig
2011-04-18 18:11 ` Steven Rostedt
2011-04-19 1:08 ` liubo [this message]
2011-04-19 1:35 ` [PATCH 1/2] tracing: " liubo
2011-04-29 10:01 ` liubo
2011-05-01 15:35 ` Steven Rostedt
2011-05-26 5:49 ` liubo
2011-05-25 12:27 ` Steven Rostedt
2011-05-25 16:12 ` Randy Dunlap
2011-05-25 16:47 ` Steven Rostedt
2011-05-25 16:50 ` Randy Dunlap
2011-05-26 1:08 ` Li Zefan
2011-05-26 1:17 ` Steven Rostedt
2011-04-19 1:35 ` [PATCH 2/2] tracing: update btrfs's tracepoints to use u64 interface liubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DACE085.9070202@cn.fujitsu.com \
--to=liubo2009@cn.fujitsu.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).