linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
Cc: Chris Mason <chris.mason@oracle.com>,
	liubo <liubo2009@cn.fujitsu.com>,
	Linux Btrfs <linux-btrfs@vger.kernel.org>,
	Josef Bacik <josef@redhat.com>
Subject: bug caused by removal of trans_mutex? (Was: Re: kernel BUG at fs/btrfs/extent-tree.c:6164!)
Date: Mon, 13 Jun 2011 15:13:13 +0800	[thread overview]
Message-ID: <4DF5B889.5080202@cn.fujitsu.com> (raw)
In-Reply-To: <4DEF04CF.8010502@jp.fujitsu.com>

Cc: Josef

>>>>>>>> I encountered following panic using 'btrfs-unstable + for-linus'
>>>>>>>> kernel.
>>>>>>>>
>>>>>>>> I ran "btrfs fi bal /test5" command, and mount option of /test5
>>>>>>>> is as follows:
>>>>>>>>
>>>>>>>>  /dev/sdc3 on /test5 type btrfs (rw,space_cache,compress=lzo,inode_cache)
>>>>>>>>
>>>>>>> So, just a "btrfs fi bal" would lead to the bug?
>>>>>> I think so.
>>
>> It should be specific to the inode caching code.  The balancing code is
>> finding the inode map cache extents, but it doesn't know how to relocate
>> them.
> 
> However, the panic has occurred even if inode_cahce is turned off.
> Is this another problem?
> 

I don't think free inode cache isthe cause of the bug here (even if inode_cache
is turned on).

What I have found out is:

1. git checkout a4abeea41adfa3c143c289045f4625dfaeba2212

So the top commit is the removal of trans_mutex and no delayed_inode patch
or free inode cache patchset in the tree, and bug can be triggered.

2. git checkout 2a1eb4614d984d5cd4c928784e9afcf5c07f93be

So the top commit is the one before trans_mutex removal, and no bug triggered.

3. test linus' tree

bug triggered.

4. revert that suspicoius commit manually from linus' tree

no bug.

so either that commit is buggy or it reveals some bugs covered by the trans_mutex.


  reply	other threads:[~2011-06-13  7:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-06  8:33 kernel BUG at fs/btrfs/extent-tree.c:6164! Tsutomu Itoh
2011-06-07  5:31 ` liubo
2011-06-07  5:59   ` Tsutomu Itoh
2011-06-07  6:17     ` Tsutomu Itoh
2011-06-07  8:24       ` Tsutomu Itoh
2011-06-07  8:36         ` liubo
2011-06-07 15:46           ` Chris Mason
2011-06-08  5:12             ` Tsutomu Itoh
2011-06-13  7:13               ` Li Zefan [this message]
2011-06-13  7:49                 ` bug caused by removal of trans_mutex? (Was: Re: kernel BUG at fs/btrfs/extent-tree.c:6164!) Yan, Zheng 
2011-06-13  8:26                   ` Li Zefan
2011-06-13 13:12                 ` Chris Mason
2011-06-13 15:18                   ` Chris Mason
2011-06-13 14:58                 ` Yan, Zheng 
2011-06-13 15:09                   ` Chris Mason
2011-06-13 19:55                   ` Chris Mason
2011-06-14  3:24                     ` Yan, Zheng 
2011-06-14  5:44                       ` Li Zefan
2011-06-14  6:53                 ` Yan, Zheng 

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF5B889.5080202@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=chris.mason@oracle.com \
    --cc=josef@redhat.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=liubo2009@cn.fujitsu.com \
    --cc=t-itoh@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).