From: Josef Bacik <josef@redhat.com>
To: Jim Schutt <jaschut@sandia.gov>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: set no_trans_join after trying to expand the transaction
Date: Wed, 15 Jun 2011 10:40:17 -0400 [thread overview]
Message-ID: <4DF8C451.4060000@redhat.com> (raw)
In-Reply-To: <4DF8C353.9090301@sandia.gov>
On 06/15/2011 10:36 AM, Jim Schutt wrote:
>
> Josef Bacik wrote:
>> We can lockup if we try to allow new writers join the transaction and
>> we have
>> flushoncommit set or have a pending snapshot. This is because we set
>> no_trans_join and then loop around and try to wait for ordered extents
>> again.
>> The problem is the ordered endio stuff needs to join the transaction,
>> which it
>> can't do because no_trans_join is set. So instead wait until after
>> this loop to
>> set no_trans_join and then make sure to wait for num_writers == 1 in case
>> anybody got started in between us exiting the loop and setting
>> no_trans_join.
>> This could easily be reproduced by mounting -o flushoncommit and
>> running xfstest
>> 13. It cannot be reproduced with this patch. Thanks,
>
> FWIW, this version of the patch works fine for me
> as well.
>
Great, thanks for testing.
Josef
prev parent reply other threads:[~2011-06-15 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 20:25 [PATCH] Btrfs: set no_trans_join after trying to expand the transaction Josef Bacik
2011-06-15 14:36 ` Jim Schutt
2011-06-15 14:40 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF8C451.4060000@redhat.com \
--to=josef@redhat.com \
--cc=jaschut@sandia.gov \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).