From: Andreas Philipp <philipp.andreas@gmail.com>
To: Stephane Chazelas <stephane.chazelas@gmail.com>
Cc: Hugo Mills <hugo@carfax.org.uk>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] [btrfs-progs integration] incorrect argument checking for "btrfs sub snap -r"
Date: Thu, 30 Jun 2011 22:55:15 +0200 [thread overview]
Message-ID: <4E0CE2B3.1080600@gmail.com> (raw)
In-Reply-To: <chaz20110630123438.GE28702@seebyte.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 30.06.2011 14:34, Stephane Chazelas wrote:
> Looks like this was missing in integration-20110626 for the
> readonly snapshot patch:
>
> diff --git a/btrfs.c b/btrfs.c
> index e117172..be6ece5 100644
> --- a/btrfs.c
> +++ b/btrfs.c
> @@ -49,7 +49,7 @@ static struct Command commands[] = {
> /*
> avoid short commands different for the case only
> */
> - { do_clone, 2,
> + { do_clone, -1,
> "subvolume snapshot", "[-r] <source> [<dest>/]<name>\n"
> "Create a writable/readonly snapshot of the subvolume <source> with\n"
> "the name <name> in the <dest> directory.",
>
> Without that, "btrfs sub snap -r x y" would fail as it's not *2*
> arguments.
Unfortunately, this is not correct either. "-1" means that the minimum
number of arguments is 1 and since we need at least <source> and
<name> this is 2. So the correct version should be -2.
Thanks,
Andreas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJODOKyAAoJEJIcBJ3+XkgiEzEP/1vXuvIqPvWQ6Yg3KGW31vZB
80BZRUIKJQel2VqZ8NN4mNJoXPsQ3r21gTv9aZQwHHnCRszBCDqo5uhJUIKfVsWX
WIOkQo6uJLUeO5tCwuIGBDwzy8WBgFyCNhUT06GVNJxNP2WZddsp3Wo540Mmmoof
en3+4SPC5godW2+t80811le+bfQpZ1N+Q2MXLTx0ilvt3y2cCjoV26yIhRj1mzOn
QBKRZCwvMafmE9jBdZLIx4h+W3agT3EWQj9F7c4ZsJFsrc5SJWtjMNZrWg8aRtYR
YFcHwuAH4IzVHxB0a84tiCtH+N+fnmQpXUWUZGjJLODgmJnJ+wq/vi1ek2J8Dw+c
pF3E+U6oy/bX/sQ7Ef/Zxs3qlp88hgLypd9Y2/Lk7i0XmKNYxpg9KisMiAS+Ensa
ucb0lNxB1rCSEtN48JfWJ55aA0Yh4B1WompXuRseekcVKFuOW/OqBkE73Q0YBSQo
FogqVGvrdmfgAeC8Uft83oo1zXXNYoxIpP5PjPgmpgwBQihZDHfVqbagFhKnRsRq
bsXyzl2C7SkgVUxtuD3/Co3uyFm/So9MsgJmkcDDGo4APhUGxSOxGqhWo49C/1CZ
xfUSC1+rYnzTwK+5vhjbJjjXTdjaRGprcEH0803+cVikPdOSYfKsztrf+9OGSAp7
J+vEuVEESjhEcn2ySfSx
=bSbf
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-06-30 20:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 14:37 subvolumes missing from "btrfs subvolume list" output Stephane Chazelas
2011-06-29 15:00 ` Stephane Chazelas
2011-06-29 16:16 ` Josef Bacik
2011-06-29 16:47 ` Hugo Mills
2011-06-29 16:50 ` Hugo Mills
2011-06-29 20:41 ` Goffredo Baroncelli
2011-06-30 0:47 ` Li Zefan
2011-06-30 8:40 ` Stephane Chazelas
2011-06-30 9:18 ` Andreas Philipp
2011-06-30 10:43 ` Stephane Chazelas
2011-06-30 10:52 ` Andreas Philipp
2011-06-30 10:54 ` Hugo Mills
2011-06-30 10:58 ` Hugo Mills
2011-06-30 12:34 ` [PATCH] [btrfs-progs integration] incorrect argument checking for "btrfs sub snap -r" Stephane Chazelas
2011-06-30 13:07 ` Hugo Mills
2011-06-30 20:55 ` Andreas Philipp [this message]
2011-06-30 21:09 ` Hugo Mills
2011-07-01 8:26 ` [PATCH] " Stephane Chazelas
2011-07-01 10:13 ` Andreas Philipp
2011-07-01 10:42 ` Hugo Mills
2011-07-01 12:55 ` Stephane Chazelas
2011-08-11 4:30 ` Tsutomu Itoh
2011-08-11 6:45 ` Andreas Philipp
2011-08-11 12:40 ` Hugo Mills
2011-07-01 1:08 ` subvolumes missing from "btrfs subvolume list" output Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0CE2B3.1080600@gmail.com \
--to=philipp.andreas@gmail.com \
--cc=hugo@carfax.org.uk \
--cc=linux-btrfs@vger.kernel.org \
--cc=stephane.chazelas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).