From: Li Zefan <lizf@cn.fujitsu.com>
To: David Sterba <dsterba@suse.cz>,
linux-btrfs@vger.kernel.org, chris.mason@oracle.com,
josef@redhat.com, miaox@cn.fujitsu.com, list.btrfs@jan-o-sch.net
Subject: Re: [RFC, crash][PATCH] btrfs: allow cross-subvolume file clone
Date: Thu, 04 Aug 2011 10:42:09 +0800 [thread overview]
Message-ID: <4E3A0701.6080900@cn.fujitsu.com> (raw)
In-Reply-To: <20110803182226.GD28122@twin.jikos.cz>
David Sterba wrote:
> On Wed, Aug 03, 2011 at 08:07:42PM +0200, David Sterba wrote:
>> I'm working on a patch to fix cross-volume cloning, worked for simple cases
>> like cloning a single file. When I cloned a full linux-2.6 tree there was a
>> immediate BUG_ON (after third cloned file) in btrfs_delayed_update_inode
>> with -ENOSPC :
>
> oh, a similar issue was already reported on 5 Jul 2011:
>
> "[BUG] delayed inodes and reflinks"
> http://permalink.gmane.org/gmane.comp.file-systems.btrfs/11763
>
We've got four reports on this bug.
The cause is we didn't reserve enough space when starting a transaction.
We need space for:
1. btrfs_insert_empty_item()
2. btrfs_update_inode()
3. btrfs_drop_extents()
The first 2 are easy, but drop_extents is not, we have to calc the space
needed for drop_extents in worst case.
--
Li Zefan
next prev parent reply other threads:[~2011-08-04 2:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 18:07 [RFC, crash][PATCH] btrfs: allow cross-subvolume file clone David Sterba
2011-08-03 18:22 ` David Sterba
2011-08-04 2:42 ` Li Zefan [this message]
2011-08-04 1:19 ` Miao Xie
2011-08-09 17:50 ` David Sterba
2011-08-12 1:27 ` Dan Merillat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3A0701.6080900@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=chris.mason@oracle.com \
--cc=dsterba@suse.cz \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=list.btrfs@jan-o-sch.net \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox