From: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
To: Wanlong Gao <wanlong.gao@gmail.com>
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
chris.mason@oracle.com
Subject: Re: [PATCH] btrfs:make btrfs_init_compress() return void
Date: Tue, 23 Aug 2011 08:43:02 +0900 [thread overview]
Message-ID: <4E52E986.8030405@jp.fujitsu.com> (raw)
In-Reply-To: <1314022940-6717-1-git-send-email-wanlong.gao@gmail.com>
(2011/08/22 23:22), Wanlong Gao wrote:
> From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>
> Make btrfs_init_compress() return void, since it always return 0,
> and no need to check return value.
>
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> ---
> fs/btrfs/compression.c | 3 +--
> fs/btrfs/compression.h | 2 +-
> fs/btrfs/super.c | 7 ++-----
> 3 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c
> index 8ec5d86..b2dbefa 100644
> --- a/fs/btrfs/compression.c
> +++ b/fs/btrfs/compression.c
> @@ -731,7 +731,7 @@ struct btrfs_compress_op *btrfs_compress_op[] = {
> &btrfs_lzo_compress,
> };
>
> -int __init btrfs_init_compress(void)
> +void __init btrfs_init_compress(void)
> {
> int i;
>
> @@ -741,7 +741,6 @@ int __init btrfs_init_compress(void)
> atomic_set(&comp_alloc_workspace[i], 0);
> init_waitqueue_head(&comp_workspace_wait[i]);
> }
> - return 0;
> }
>
> /*
> diff --git a/fs/btrfs/compression.h b/fs/btrfs/compression.h
> index a12059f..9afb0a6 100644
> --- a/fs/btrfs/compression.h
> +++ b/fs/btrfs/compression.h
> @@ -19,7 +19,7 @@
> #ifndef __BTRFS_COMPRESSION_
> #define __BTRFS_COMPRESSION_
>
> -int btrfs_init_compress(void);
> +void btrfs_init_compress(void);
> void btrfs_exit_compress(void);
>
> int btrfs_compress_pages(int type, struct address_space *mapping,
> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
> index 15634d4..31e9654 100644
> --- a/fs/btrfs/super.c
> +++ b/fs/btrfs/super.c
> @@ -1238,9 +1238,7 @@ static int __init init_btrfs_fs(void)
> if (err)
> return err;
>
> - err = btrfs_init_compress();
> - if (err)
> - goto free_sysfs;
> + btrfs_init_compress();
>
> err = btrfs_init_cachep();
> if (err)
> @@ -1281,8 +1279,7 @@ free_cachep:
> btrfs_destroy_cachep();
> free_compress:
> btrfs_exit_compress();
> -free_sysfs:
> - btrfs_exit_sysfs();
> +
Why remove btrfs_exit_sysfs()?
-Tsutomu
> return err;
> }
>
next prev parent reply other threads:[~2011-08-22 23:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 14:22 [PATCH] btrfs:make btrfs_init_compress() return void Wanlong Gao
2011-08-22 23:43 ` Tsutomu Itoh [this message]
2011-08-23 0:05 ` Wanlong Gao
2011-08-23 0:16 ` [PATCH v2] " Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E52E986.8030405@jp.fujitsu.com \
--to=t-itoh@jp.fujitsu.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wanlong.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).