From: Li Zefan <lizf@cn.fujitsu.com>
To: Wanlong Gao <wanlong.gao@gmail.com>
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
chris.mason@oracle.com, Wanlong Gao <gaowanlong@cn.fujitsu.com>
Subject: Re: [PATCH] btrfs:make close_ctree() return void
Date: Tue, 23 Aug 2011 09:00:24 +0800 [thread overview]
Message-ID: <4E52FBA8.8020508@cn.fujitsu.com> (raw)
In-Reply-To: <1314026291-8873-1-git-send-email-wanlong.gao@gmail.com>
Wanlong Gao wrote:
> From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>
> Make close_ctree() return void since it always return 0, and fix
> the return value of btrfs_put_super() to consistent with VFS.
>
I don't quite like this patch. We do have some failure cases in
close_ctree(), but this doesn't fix that while have the FIXME
tag removed.
--
Li Zefan
prev parent reply other threads:[~2011-08-23 1:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 15:18 [PATCH] btrfs:make close_ctree() return void Wanlong Gao
2011-08-23 1:00 ` Li Zefan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E52FBA8.8020508@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=chris.mason@oracle.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wanlong.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).