From: Jan Schmidt <list.btrfs@jan-o-sch.net>
To: linux-btrfs@vger.kernel.org
Cc: slyich@gmail.com, chris.mason@oracle.com,
Sergei Trofimovich <slyfox@gentoo.org>
Subject: Re: [btrfs-progs: PATCH] scrub: fix build failure by restoring proper library ordering
Date: Mon, 07 Nov 2011 14:25:25 +0100 [thread overview]
Message-ID: <4EB7DC45.6070407@jan-o-sch.net> (raw)
In-Reply-To: <20111107124523.GN12759@twin.jikos.cz>
Hi David,
On 07.11.2011 13:45, David Sterba wrote:
> On Mon, Nov 07, 2011 at 10:19:33AM +0300, slyich@gmail.com wrote:
>> btrfs: $(objects) btrfs.o btrfs_cmds.o scrub.o
>> - $(CC) -lpthread $(CFLAGS) -o btrfs btrfs.o btrfs_cmds.o scrub.o \
>> - $(objects) $(LDFLAGS) $(LIBS)
>> + $(CC) $(CFLAGS) -o btrfs btrfs.o btrfs_cmds.o scrub.o \
>> + $(objects) $(LDFLAGS) $(LIBS) -lpthread
>
> No, it's "-pthread", adds both preprocessor and linker flags.
It seems to do the right thing on x86_64, although...
If I'm reading my gcc manpage right, it is telling me to use -pthread
only for ia64 on HPUX, powerpc and sparc. (gcc 4.4.5 that is)
-Jan
prev parent reply other threads:[~2011-11-07 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 7:19 [btrfs-progs: PATCH] scrub: fix build failure by restoring proper library ordering slyich
2011-11-07 12:45 ` David Sterba
2011-11-07 13:25 ` Jan Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB7DC45.6070407@jan-o-sch.net \
--to=list.btrfs@jan-o-sch.net \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=slyfox@gentoo.org \
--cc=slyich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox