Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Phillip Susi <psusi@cfl.rr.com>
To: helmut@hullen.de
Cc: Helmut Hullen <Hullen@t-online.de>, linux-btrfs@vger.kernel.org
Subject: Re: Resize command syntax wrong?
Date: Wed, 30 Nov 2011 19:01:44 -0500	[thread overview]
Message-ID: <4ED6C3E8.60009@cfl.rr.com> (raw)
In-Reply-To: <ByrPr1UD1uB@helmut.hullen.de>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/30/2011 01:59 PM, Helmut Hullen wrote:
> Hallo, Phillip,
> 
> Du meintest am 30.11.11:
> 
>> Currently the resize command is under filesystem, and takes a path to
>> the mounted filesystem.  This seems wrong to me.  Shouldn't it be
>> under device, and take a path to a device to resize?
> 
> No - it's a filesystem operation.

No, it isn't.  You can see the function that implements the resize in the code operates on a specific disk, and the ioctl does take as an argument which disk you are trying to resize.  Logically you are adjusting the space that is available on a particular device, which only indirectly affects the filesystem.  In other words, the only reason that the size of the filesystem changes is because you have changed the size of a device.  In fact, internally device removal is implemented by first resizing the device to 0.

It appears that the utility just passes devid=1 to the kernel when you don't specify it.  It should take a dev node as an argument and translate it to the devid for you.

> p.e.
> You start with a system of 2 disks. They get filled nearly  
> simultaneously.
> Then you add a 3rd disk (which is empty at that time). Now it's a good  
> idea to run "balance" for equalizing the filling.

balance != resize

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk7Ww+gACgkQJ4UciIs+XuJjlwCgr2u3zvuhYWC0vv9ObdhBS41Z
M3MAn09xhEopzuIJdN4QP+8bQvYzhvo1
=Qck2
-----END PGP SIGNATURE-----

  parent reply	other threads:[~2011-12-01  0:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30 18:47 Resize command syntax wrong? Phillip Susi
2011-11-30 18:59 ` Helmut Hullen
2011-11-30 19:15   ` Roman Mamedov
2011-11-30 19:37     ` Goffredo Baroncelli
2011-11-30 19:43     ` Helmut Hullen
2011-11-30 20:07       ` Roman Mamedov
2011-11-30 20:48         ` Goffredo Baroncelli
2011-11-30 20:55         ` Helmut Hullen
2011-12-01  0:01   ` Phillip Susi [this message]
2011-12-01  6:46     ` Helmut Hullen
2011-12-01 15:57       ` Phillip Susi
2011-12-01 16:19         ` Helmut Hullen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED6C3E8.60009@cfl.rr.com \
    --to=psusi@cfl.rr.com \
    --cc=Hullen@t-online.de \
    --cc=helmut@hullen.de \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox