From: Phillip Susi <psusi@cfl.rr.com>
To: Josef Bacik <josef@redhat.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: don't panic if orphan item already exists
Date: Tue, 13 Dec 2011 14:03:14 -0500 [thread overview]
Message-ID: <4EE7A172.2010105@cfl.rr.com> (raw)
In-Reply-To: <1323798951-4329-1-git-send-email-josef@redhat.com>
On 12/13/2011 12:55 PM, Josef Bacik wrote:
> I've been hitting this BUG_ON() in btrfs_orphan_add when running xfstest 269 in
> a loop. This is because we will add an orphan item, do the truncate, the
> truncate will fail for whatever reason (*cough*ENOSPC*cough*) and then we're
> left with an orphan item still in the fs. Then we come back later to do another
> truncate and it blows up because we already have an orphan item. This is ok so
> just fix the BUG_ON() to only BUG() if ret is not EEXIST. Thanks,
Wouldn't it be better to fix the underlying bug, and remove the orphan
item when the truncate fails?
next prev parent reply other threads:[~2011-12-13 19:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 17:55 [PATCH] Btrfs: don't panic if orphan item already exists Josef Bacik
2011-12-13 19:03 ` Phillip Susi [this message]
2011-12-13 19:09 ` Josef Bacik
2011-12-14 2:07 ` WuBo
2011-12-14 9:46 ` Miao Xie
2011-12-14 14:58 ` Josef Bacik
2011-12-14 15:14 ` Phillip Susi
2011-12-14 15:27 ` Josef Bacik
2011-12-14 15:41 ` Phillip Susi
2011-12-14 15:46 ` Josef Bacik
2011-12-14 19:59 ` Phillip Susi
2011-12-14 15:34 ` Josef Bacik
2011-12-14 15:35 ` Josef Bacik
2011-12-14 16:45 ` Chris Mason
2011-12-14 16:47 ` Josef Bacik
2011-12-15 1:42 ` Miao Xie
2011-12-15 1:56 ` WuBo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE7A172.2010105@cfl.rr.com \
--to=psusi@cfl.rr.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).