From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jan Schmidt <list.btrfs@jan-o-sch.net>,
xfs@oss.sgi.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] xfstests: new check 278 to ensure btrfs backref integrity
Date: Wed, 04 Jan 2012 11:01:50 -0600 [thread overview]
Message-ID: <4F0485FE.8000405@sandeen.net> (raw)
In-Reply-To: <20120104163946.GA8153@infradead.org>
On 1/4/12 10:39 AM, Christoph Hellwig wrote:
> On Thu, Dec 22, 2011 at 12:08:58PM +0100, Jan Schmidt wrote:
>> This is a btrfs specific scratch test checking the backref walker. It
>> creates a file system with compressed and uncompressed data extents, picks
>> files randomly and uses filefrag to get their extents. It then asks the
>> btrfs utility (inspect-internal) to do the backref resolving from fs-logical
>> address (the one filefrag calls "physical") back to the inode number and
>> file-logical offset, verifying the result.
>
> I was about to apply this, but for some reason it fails for me when
> running xfstest on xfs:
>
> 276 [failed, exit status 1] - output mismatch (see 276.out.bad)
> --- 276.out 2012-01-04 16:14:36.000000000 +0000
> +++ 276.out.bad 2012-01-04 16:32:26.000000000 +0000
> @@ -1,4 +1,5 @@
> QA output created by 276
> -*** test backref walking
> -*** done
> +common.rc: Error: $TEST_DEV (/dev/vdb1) is not a MOUNTED btrfs
> filesystem
> +Filesystem Type 1K-blocks Used Available Use% Mounted on
> +/dev/vdb1 xfs 39042944 32928 39010016 1% /mnt/test
> *** unmount
>
> which is a bit confusing
>
276 got merged on Dec 28 before my requests for fixup, I guess? And it
explicitly sets FSTYP=btrfs which is why it fails.
the 278 patch v2 in this thread works ok for me.
so munging the 278 patch here into the existing 276 should be the
right approach.
-Eric
next prev parent reply other threads:[~2012-01-04 17:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 11:08 [PATCH v2] xfstests: new check 278 to ensure btrfs backref integrity Jan Schmidt
2012-01-04 16:39 ` Christoph Hellwig
2012-01-04 17:01 ` Eric Sandeen [this message]
2012-01-04 17:04 ` Jan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0485FE.8000405@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=list.btrfs@jan-o-sch.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).