From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Zefan Subject: Re: Updated btrfs/crypto snappy interface ready for merging Date: Tue, 17 Jan 2012 17:27:22 +0800 Message-ID: <4F153EFA.4070404@cn.fujitsu.com> References: <1326414530-10789-1-git-send-email-andi@firstfloor.org> <20120116135442.GA28487@shiny> <4F1534FD.30707@cn.fujitsu.com> <20120117084650.GP11715@one.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Chris Mason , linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org To: Andi Kleen Return-path: In-Reply-To: <20120117084650.GP11715@one.firstfloor.org> List-ID: Andi Kleen wrote: >> It's because decompressing inline extents always fails. I've fixed it >> and will send the patch out in a new mail thread. > > Thanks for fixing. > >> >> But seems there's bug in lib snappy code, which makes the decompressed >> data doesn't quite match the original data. >> >> Simply copy a file to a btrfs filesystem with snappy enabled, and clear >> page cache, and check the file: > > Hmm weird, I have never seen this. Do you have a reproducer? > > The basic compression code is quite well tested, I have a reasonable > unit test. > At first I saved emails and patched them in linux-btrfs git tree, and I got weired result. Then I pulled the snappy branch directly, and now nothing is wrong.. Sorry for the noise.