From: Miao Xie <miaox@cn.fujitsu.com>
To: Jan Schmidt <list.btrfs@jan-o-sch.net>
Cc: Chris Mason <chris.mason@oracle.com>,
Linux Btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [RFC][PATCH 1/2] Btrfs: try to allocate new chunks with degenerated profile
Date: Thu, 19 Jan 2012 13:58:32 +0800 [thread overview]
Message-ID: <4F17B108.1020103@cn.fujitsu.com> (raw)
In-Reply-To: <4F169B04.3060200@jan-o-sch.net>
On wed, 18 Jan 2012 11:12:20 +0100, Jan Schmidt wrote:
> On 17.01.2012 21:58, Chris Mason wrote:
>> These two didn't make my first pull request just because I wanted to get
>> something out the door. I'll definitely have them in the next pull.
>
> Please, don't do that! You can't just degenerate to DUP when RAID1 is
> out of space, that's entirely different.
>
> It's debatable whether degeneration from RAID0 to single is acceptable,
> but that again has different characteristics.
>
> ENOSPC is the best choice for both in my opinon.
I understand what you said, but in fact, the free space allocator can degenerate
the profile if it doesn't find enough free space. This patch just follows the
rule which exists in the current code.
Maybe adding a new mount option is another good option.
Thanks
Miao
>
> -Jan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-01-19 5:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 10:02 [RFC][PATCH 1/2] Btrfs: try to allocate new chunks with degenerated profile Miao Xie
2012-01-17 20:58 ` Chris Mason
2012-01-18 10:12 ` Jan Schmidt
2012-01-18 12:41 ` Hugo Mills
2012-01-18 13:42 ` Roman Kapusta
2012-01-19 5:58 ` Miao Xie [this message]
2012-01-20 10:36 ` Jan Schmidt
2012-01-18 10:14 ` Arne Jansen
2012-01-18 12:34 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F17B108.1020103@cn.fujitsu.com \
--to=miaox@cn.fujitsu.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=list.btrfs@jan-o-sch.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).