linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Liu Bo <liubo2009@cn.fujitsu.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] xfstests: add btrfs online defragments QA test
Date: Tue, 07 Feb 2012 09:21:24 +0800	[thread overview]
Message-ID: <4F307C94.2020004@cn.fujitsu.com> (raw)
In-Reply-To: <20120206121155.GA16044@infradead.org>

On 02/06/2012 08:11 PM, Christoph Hellwig wrote:
> On Mon, Feb 06, 2012 at 04:27:49PM +0800, Liu Bo wrote:
>> +_runtest()
>> +{
>> +	$progs_dir/runtest.sh $defrag_args $SCRATCH_MNT $SCRATCH_DEV
> 
> please put the actual tests into test cases themselves instead of
> calling out into shell scripts under src.  If you have common code
> shared between multiple tests please put them into common.defrag.
> 

I see, will update it.

>> +
>> +# get standard environment, filters and checks
>> +. ./common.rc
>> +. ./common.filter
>> +. ./common.defrag
>> +
>> +# real QA test starts here
>> +_supported_fs xfs btrfs
> 
> does it really support xfs?
> 

sorry, my miss.

Thanks for reviewing!

thanks,
liubo

> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


  reply	other threads:[~2012-02-07  1:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-06  8:27 [PATCH 1/3][RESEND] xfstests: fix 251's cp -axT problem Liu Bo
2012-02-06  8:27 ` [PATCH 2/3][RESEND] xfstests: make 218 support btrfs Liu Bo
2012-03-31 20:12   ` [PATCH 2/3][RESEND] 218: " Christoph Hellwig
2012-02-06  8:27 ` [PATCH 3/3] xfstests: add btrfs online defragments QA test Liu Bo
2012-02-06 12:11   ` Christoph Hellwig
2012-02-07  1:21     ` Liu Bo [this message]
2012-03-31 20:11 ` [PATCH 1/3][RESEND] 251: fix cp -axT problem Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F307C94.2020004@cn.fujitsu.com \
    --to=liubo2009@cn.fujitsu.com \
    --cc=hch@infradead.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).