linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arne Jansen <sensille@gmx.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: btrfs: initial readahead code and prototypes
Date: Thu, 17 May 2012 17:33:34 +0200	[thread overview]
Message-ID: <4FB51A4E.6000501@gmx.net> (raw)
In-Reply-To: <20120517134613.GN16999@mwanda>

On 05/17/12 15:46, Dan Carpenter wrote:
> On Thu, May 17, 2012 at 03:31:50PM +0200, Arne Jansen wrote:
>> The assumption here is that if err == 0, eb is always != NULL. There's
>> even a tiny comment above the function stating this:
>>
>>        107              /* in case of err, eb might be NULL */
>>
>
> Ah, right.  I missed the comment.

Thanks for doing this kind of sanity checking :)

-Arne

>
>> This code changes significantly with the patch
>>
>> btrfs: extend readahead interface
>>
>> Where it is written in a more obvious way.
>
> Cool.
>
> regards,
> dan carpenter
>


      reply	other threads:[~2012-05-17 15:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-17  7:14 btrfs: initial readahead code and prototypes Dan Carpenter
2012-05-17 13:31 ` Arne Jansen
2012-05-17 13:46   ` Dan Carpenter
2012-05-17 15:33     ` Arne Jansen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB51A4E.6000501@gmx.net \
    --to=sensille@gmx.net \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).