From: Goffredo Baroncelli <kreijack@libero.it>
To: Andrei Popa <ierdnah@gmail.com>,
linux-btrfs@vger.kernel.org, arnd@arndnet.de
Subject: Re: [PATCH] Btrfs: add "nocompress" mount option
Date: Fri, 15 Jun 2012 18:56:35 +0200 [thread overview]
Message-ID: <4FDB6943.2030601@libero.it> (raw)
In-Reply-To: <20120615105006.GV32402@twin.jikos.cz>
On 06/15/2012 12:50 PM, David Sterba wrote:
> I prefer this over adding an extra option to disable. This
> way there's no confusion if the compression is on or off.
>
> mount -o compress,nocompress /dev /mnt
The confusion still exists if an user does:
mount -o compress,compress=no /dev /mnt
However I prefer the form "compress=" because already exists the option
"compress=lzo|zlib".
BR
G.Baroncelli
>
> Is it on or off? Yeah we can document that nocompress has higher
> priority. But then I can't turn a nocompress option back to compress via
> remount. This is possible with Arnd's patch.
>
>
> david
next prev parent reply other threads:[~2012-06-15 16:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 9:56 [PATCH] Btrfs: add "nocompress" mount option Andrei Popa
2012-06-15 10:50 ` David Sterba
2012-06-15 11:13 ` Andrei Popa
2012-06-15 14:27 ` Andrei Popa
2012-06-18 12:28 ` David Sterba
2012-06-15 16:56 ` Goffredo Baroncelli [this message]
2012-06-18 12:20 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDB6943.2030601@libero.it \
--to=kreijack@libero.it \
--cc=arnd@arndnet.de \
--cc=ierdnah@gmail.com \
--cc=kreijack@inwind.it \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox