btrfs_print_tree?

btrfs_print_tree?

[Zhi Yong Wu]

HI,

Do anyone know where btrfs_print_tree is invoked? thanks.

-- 
Regards,

Zhi Yong Wu

Re: btrfs_print_tree?

[Mike Fleetwood]

On 1 July 2012 05:53, Zhi Yong Wu <zwu.kernel@gmail.com> wrote:
> HI,
>
> Do anyone know where btrfs_print_tree is invoked? thanks.
>
> --
> Regards,
>
> Zhi Yong Wu

Is this the answer you are after?

$ grep -r btrfs_print_tree fs/btrfs/
fs/btrfs/print-tree.c:void btrfs_print_tree(struct btrfs_root *root,
struct extent_buffer *c)
fs/btrfs/print-tree.c:		btrfs_print_tree(root, next);
fs/btrfs/print-tree.h:void btrfs_print_tree(struct btrfs_root *root,
struct extent_buffer *t);

Mike

Re: btrfs_print_tree?

[Zhi Yong Wu]

On Sun, Jul 1, 2012 at 5:41 PM, Mike Fleetwood
<mike.fleetwood@googlemail.com> wrote:
> On 1 July 2012 05:53, Zhi Yong Wu <zwu.kernel@gmail.com> wrote:
>> HI,
>>
>> Do anyone know where btrfs_print_tree is invoked? thanks.
>>
>> --
>> Regards,
>>
>> Zhi Yong Wu
>
> Is this the answer you are after?
>
> $ grep -r btrfs_print_tree fs/btrfs/
> fs/btrfs/print-tree.c:void btrfs_print_tree(struct btrfs_root *root,
> struct extent_buffer *c)
> fs/btrfs/print-tree.c:          btrfs_print_tree(root, next);
> fs/btrfs/print-tree.h:void btrfs_print_tree(struct btrfs_root *root,
> struct extent_buffer *t);
No, i also did as this, but didn't find out who will invoke this
function. From above output, we only saw that it invokes itself one
time.

>
> Mike



-- 
Regards,

Zhi Yong Wu

Re: btrfs_print_tree?

[Andreas Philipp]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
 
On 01.07.2012 11:49, Zhi Yong Wu wrote:
> On Sun, Jul 1, 2012 at 5:41 PM, Mike Fleetwood
> <mike.fleetwood@googlemail.com> wrote:
>> On 1 July 2012 05:53, Zhi Yong Wu <zwu.kernel@gmail.com> wrote:
>>> HI,
>>>
>>> Do anyone know where btrfs_print_tree is invoked? thanks.
>>>
>>> --
>>> Regards,
>>>
>>> Zhi Yong Wu
>>
>> Is this the answer you are after?
>>
>> $ grep -r btrfs_print_tree fs/btrfs/
>> fs/btrfs/print-tree.c:void btrfs_print_tree(struct btrfs_root *root,
>> struct extent_buffer *c)
>> fs/btrfs/print-tree.c: btrfs_print_tree(root, next);
>> fs/btrfs/print-tree.h:void btrfs_print_tree(struct btrfs_root *root,
>> struct extent_buffer *t);
> No, i also did as this, but didn't find out who will invoke this
> function. From above output, we only saw that it invokes itself one
> time.
Is this function unused then?

Andreas
>
>
>>
>> Mike
>
>
>


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
 
iQEcBAEBAgAGBQJP8CNFAAoJEIW3W1BiBxU7C40H/0ecIgo1AagGyh/q4tLjXxAZ
PILqpKZzGiX6Qc+qWnaHrNyCJU1ntppO73k/SmhMpx+xycw/qHbqKtCpw/W8aQfn
ihKOP9amgCUR/X+1W7hn190r0c1teWnXV/bYoD81fksWYuZmG9XzBOF4u9iLrtIb
0hpeBtFPr7jizKv3puOVKBpEV3ZMUdiqwc+G5GxUSlOssqKdF38gHGvj1k3j1qTX
0JRndsaeZq0smA0RJnYa9nX7gvg8CnmUXIJ/yLgg8Rnn5LhJQoq2eK4fgE+I0OCy
SjlzSQG78W9CnWmE6SitfVeb/QUyLdCZ/mtwPxqeKd9p06hcLCU4R89rWRnNWTQ=
=bq50
-----END PGP SIGNATURE-----

Re: btrfs_print_tree?

[Jeff Liu]

On 07/01/2012 05:49 PM, Zhi Yong Wu wrote:

> On Sun, Jul 1, 2012 at 5:41 PM, Mike Fleetwood
> <mike.fleetwood@googlemail.com> wrote:
>> On 1 July 2012 05:53, Zhi Yong Wu <zwu.kernel@gmail.com> wrote:
>>> HI,
>>>
>>> Do anyone know where btrfs_print_tree is invoked? thanks.
>>>
>>> --
>>> Regards,
>>>
>>> Zhi Yong Wu
>>
>> Is this the answer you are after?
>>
>> $ grep -r btrfs_print_tree fs/btrfs/
>> fs/btrfs/print-tree.c:void btrfs_print_tree(struct btrfs_root *root,
>> struct extent_buffer *c)
>> fs/btrfs/print-tree.c:          btrfs_print_tree(root, next);
>> fs/btrfs/print-tree.h:void btrfs_print_tree(struct btrfs_root *root,
>> struct extent_buffer *t);
> No, i also did as this, but didn't find out who will invoke this
> function. From above output, we only saw that it invokes itself one
> time.

Looks this is a helper routine exported to btrfs-progs previously, it is
used by debug-tree, quick-test, etc...

But this function has been implemented at btrfs-progs now, maybe it
could be safely removed from kernel, not sure. :)

Thanks,
-Jeff

> 
>>
>> Mike
> 
> 
> 

Re: btrfs_print_tree?

[Andreas Philipp]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
 

On 01.07.2012 12:16, Jeff Liu wrote:
> On 07/01/2012 05:49 PM, Zhi Yong Wu wrote:
>
>> On Sun, Jul 1, 2012 at 5:41 PM, Mike Fleetwood
>> <mike.fleetwood@googlemail.com> wrote:
>>> On 1 July 2012 05:53, Zhi Yong Wu <zwu.kernel@gmail.com> wrote:
>>>> HI,
>>>>
>>>> Do anyone know where btrfs_print_tree is invoked? thanks.
>>>>
>>>> --
>>>> Regards,
>>>>
>>>> Zhi Yong Wu
>>>
>>> Is this the answer you are after?
>>>
>>> $ grep -r btrfs_print_tree fs/btrfs/
>>> fs/btrfs/print-tree.c:void btrfs_print_tree(struct btrfs_root *root,
>>> struct extent_buffer *c)
>>> fs/btrfs/print-tree.c: btrfs_print_tree(root, next);
>>> fs/btrfs/print-tree.h:void btrfs_print_tree(struct btrfs_root *root,
>>> struct extent_buffer *t);
>> No, i also did as this, but didn't find out who will invoke this
>> function. From above output, we only saw that it invokes itself one
>> time.
>
> Looks this is a helper routine exported to btrfs-progs previously, it is
> used by debug-tree, quick-test, etc...
>
> But this function has been implemented at btrfs-progs now, maybe it
> could be safely removed from kernel, not sure. :)
>
> Thanks,
> -Jeff
Looks exactly the same to me.

Thanks,
Andreas

>
>
>>
>>>
>>> Mike
>>
>>
>>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
 
iQEcBAEBAgAGBQJP8CVUAAoJEIW3W1BiBxU7RMMH/A90pUdpILSWJndkJiddmbqW
17SyQMldS/xSFVHvT8ot92jyKqYhk6MFGwdkGgCX8RXCO5G5PzbxOGHxtF3j872V
J3fPp9qxTpNSEhy7uDsnyMvDFgNgXWNxz61G6ISZrubd0M0rTRdd77DrYLOqgwiQ
uTOwQ8WGPB+jOPb6+8URcPzyD82uUejIQKS4svmffPSQMY8gJEz5408HFB6SIyf/
+5/UUXwRYOlbNAVjiOVVhHWvrm1MDI1hD0S8duy2/TsS/cEt/d6xrWIJ9Ky2468y
Q62PRf6hu3GI3yxfNrEDn5i6vRVI/0EMzJHna56r1NApqa1jIIJFVbo53UyjnGw=
=3Dqd
-----END PGP SIGNATURE-----

Re: btrfs_print_tree?

[Zhi Yong Wu]

On Sun, Jul 1, 2012 at 6:16 PM, Jeff Liu <jeff.liu@oracle.com> wrote:
> On 07/01/2012 05:49 PM, Zhi Yong Wu wrote:
>
>> On Sun, Jul 1, 2012 at 5:41 PM, Mike Fleetwood
>> <mike.fleetwood@googlemail.com> wrote:
>>> On 1 July 2012 05:53, Zhi Yong Wu <zwu.kernel@gmail.com> wrote:
>>>> HI,
>>>>
>>>> Do anyone know where btrfs_print_tree is invoked? thanks.
>>>>
>>>> --
>>>> Regards,
>>>>
>>>> Zhi Yong Wu
>>>
>>> Is this the answer you are after?
>>>
>>> $ grep -r btrfs_print_tree fs/btrfs/
>>> fs/btrfs/print-tree.c:void btrfs_print_tree(struct btrfs_root *root,
>>> struct extent_buffer *c)
>>> fs/btrfs/print-tree.c:          btrfs_print_tree(root, next);
>>> fs/btrfs/print-tree.h:void btrfs_print_tree(struct btrfs_root *root,
>>> struct extent_buffer *t);
>> No, i also did as this, but didn't find out who will invoke this
>> function. From above output, we only saw that it invokes itself one
>> time.
>
> Looks this is a helper routine exported to btrfs-progs previously, it is
> used by debug-tree, quick-test, etc...
>
> But this function has been implemented at btrfs-progs now, maybe it
> could be safely removed from kernel, not sure. :)
Great, thanks both.
>
> Thanks,
> -Jeff
>
>>
>>>
>>> Mike
>>
>>
>>
>
>



-- 
Regards,

Zhi Yong Wu

Re: btrfs_print_tree?

[David Sterba]

On Sun, Jul 01, 2012 at 06:16:55PM +0800, Jeff Liu wrote:
> On 07/01/2012 05:49 PM, Zhi Yong Wu wrote:
> 
> > On Sun, Jul 1, 2012 at 5:41 PM, Mike Fleetwood
> > No, i also did as this, but didn't find out who will invoke this
> > function. From above output, we only saw that it invokes itself one
> > time.
> 
> Looks this is a helper routine exported to btrfs-progs previously, it is
> used by debug-tree, quick-test, etc...
> 
> But this function has been implemented at btrfs-progs now, maybe it
> could be safely removed from kernel, not sure. :)

Please do not remove that function, it could be helpful for debugging
prints.

david