From: Liu Bo <liubo2009@cn.fujitsu.com>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: linux-btrfs@vger.kernel.org, Alexander Block <ablock84@googlemail.com>
Subject: Re: [PATCH 1/3] Btrfs-progs: add support to set subvolume/snapshot readonly
Date: Mon, 02 Jul 2012 10:07:42 +0800 [thread overview]
Message-ID: <4FF1026E.9080007@cn.fujitsu.com> (raw)
In-Reply-To: <20120629102141.GA1877@zambezi.lan>
On 06/29/2012 06:21 PM, Ilya Dryomov wrote:
> On Fri, Jun 29, 2012 at 06:00:36PM +0800, Liu Bo wrote:
>> Setting subvolume/snapshot readonly has been missing for a long time.
>>
>> With this patch, we can set a subvolume/snapshot readonly via:
>>
>> o btrfs subvolume set-ro <path>
>
> Alexander's 'btrfs property' patches do exactly this, but in a much more
> generic and extensible way. 'btrfs property' subgroup provides a
> uniform interface for getting and setting properties of filesystem
> objects in general, not only those of subvolumes and snapshots. It
> provides a much better user interface, and it also allows us to easily
> rethink kernel-user interface for generic get/set in future.
>
Thanks for the explanation!
But I prefer keeping the current categories {subvolume,filesystem,device,...}:
o Compatibility, we cannot remove the old commands until we make sure that no users will
use them.
o We've three properties {default, readonly, lable}, is it worthy making another new interface?
o Current categories are clear and clean.
thanks,
liubo
> Thanks,
>
> Ilya
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-07-02 1:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 10:00 [PATCH 1/3] Btrfs-progs: add support to set subvolume/snapshot readonly Liu Bo
2012-06-29 10:00 ` [PATCH 2/3] Btrfs-progs: make get default report correctly Liu Bo
2012-06-29 10:36 ` Ilya Dryomov
2012-07-02 1:39 ` Liu Bo
2012-07-02 9:45 ` Ilya Dryomov
2012-07-03 1:27 ` Liu Bo
2012-06-29 10:00 ` [PATCH 3/3] Btrfs-progs: add 's' option for 'btrfs subvolume list' Liu Bo
2012-07-04 15:41 ` David Sterba
2012-07-05 12:42 ` Liu Bo
2012-06-29 10:21 ` [PATCH 1/3] Btrfs-progs: add support to set subvolume/snapshot readonly Ilya Dryomov
2012-07-02 2:07 ` Liu Bo [this message]
2012-07-02 10:00 ` Ilya Dryomov
2012-07-03 1:46 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF1026E.9080007@cn.fujitsu.com \
--to=liubo2009@cn.fujitsu.com \
--cc=ablock84@googlemail.com \
--cc=idryomov@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).