From: Zach Brown <zab@zabbo.net>
To: "Hugo Mills" <hugo@carfax.org.uk>,
"Swâmi Petaramesh" <swami@petaramesh.org>,
linux-btrfs@vger.kernel.org
Subject: Re: BTRFS fsck apparent errors
Date: Tue, 03 Jul 2012 09:26:41 -0700 [thread overview]
Message-ID: <4FF31D41.8070907@zabbo.net> (raw)
In-Reply-To: <20120703155212.GG5326@twin.jikos.cz>
On 07/03/2012 08:52 AM, David Sterba wrote:
> On Tue, Jul 03, 2012 at 04:22:08PM +0100, Hugo Mills wrote:
>> Correct, by default it just checks the filesystem. Just to be sure:
>> the filesystems in question weren't mounted, were they?
>
> fsck will refuse to run on a mounted filesystem, though in case of a
> read-only mount it might be useful during debugging, I'm using this
> patch
>
> --- a/btrfsck.c
> +++ b/btrfsck.c
> @@ -3474,6 +3474,7 @@ static struct option long_options[] = {
> { "repair", 0, NULL, 0 },
> { "init-csum-tree", 0, NULL, 0 },
> { "init-extent-tree", 0, NULL, 0 },
> + { "force", 0, NULL, 0 },
If we were to run with this, I think it should be called something other
than force. fsck.ext* has trained people to think that 'forcing' a fsck
means doing a full repair pass even if the fs thinks that it was shut
down cleanly.
--read-only would be good if fsck was taught to not even try to write in
this mode.
- z
next prev parent reply other threads:[~2012-07-03 16:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 15:10 BTRFS fsck apparent errors Swâmi Petaramesh
2012-07-03 15:22 ` Hugo Mills
2012-07-03 15:52 ` David Sterba
2012-07-03 16:26 ` Zach Brown [this message]
2012-07-03 17:37 ` David Sterba
2012-07-03 17:42 ` Zach Brown
2012-07-04 3:25 ` Dave Chinner
2012-07-03 19:17 ` Swâmi Petaramesh
2012-07-04 0:40 ` Fajar A. Nugraha
2012-07-04 13:42 ` David Sterba
2012-07-04 15:46 ` Fajar A. Nugraha
2012-07-05 0:32 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF31D41.8070907@zabbo.net \
--to=zab@zabbo.net \
--cc=hugo@carfax.org.uk \
--cc=linux-btrfs@vger.kernel.org \
--cc=swami@petaramesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox