From: Stefan Behrens <sbehrens@giantdisaster.de>
To: Jan Schmidt <list.btrfs@jan-o-sch.net>
Cc: Mark Fasheh <mfasheh@suse.de>,
linux-btrfs@vger.kernel.org, Chris Mason <chris.mason@oracle.com>,
Mark Fasheh <mfasheh@suse.com>
Subject: Re: [PATCH 1/3] btrfs: extended inode refs
Date: Fri, 06 Jul 2012 17:14:13 +0200 [thread overview]
Message-ID: <4FF700C5.5050406@giantdisaster.de> (raw)
In-Reply-To: <4FF6FCA8.2060100@jan-o-sch.net>
On Fri, 06 Jul 2012 16:56:40 +0200, Jan Schmidt wrote:
> On Mon, May 21, 2012 at 23:46 (+0200), Mark Fasheh wrote:
>> +int find_name_in_ext_backref(struct btrfs_path *path, const char *name,
>> + int name_len,
>> + struct btrfs_inode_extref **extref_ret)
>
> Exported functions should be prefixed "btrfs_". What about btrfs_find_extref_name?
>> +
>> +static struct btrfs_inode_ref *
>> btrfs_lookup_inode_ref(struct btrfs_trans_handle *trans,
>
> static functions should not be prefixed "btrfs_".
Prefixing _all_ functions with the module name has some advantages:
- uniqueness for ctags(1)
- unique names in stack traces that allow to identify the module and to
find the source code
IMO Mark should not change it.
next prev parent reply other threads:[~2012-07-06 15:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 21:46 [PATCH 0/3] btrfs: extended inode refs Mark Fasheh
2012-05-21 21:46 ` [PATCH 1/3] " Mark Fasheh
2012-07-06 14:56 ` Jan Schmidt
2012-07-06 15:14 ` Stefan Behrens [this message]
2012-07-09 19:05 ` Mark Fasheh
2012-07-09 20:33 ` Mark Fasheh
2012-05-21 21:46 ` [PATCH 2/3] " Mark Fasheh
2012-07-06 14:57 ` Jan Schmidt
2012-08-06 23:31 ` Mark Fasheh
2012-05-21 21:46 ` [PATCH 3/3] " Mark Fasheh
2012-07-06 14:57 ` Jan Schmidt
2012-07-09 20:24 ` Mark Fasheh
-- strict thread matches above, loose matches on Subject: below --
2012-08-08 18:55 [PATCH 0/3] " Mark Fasheh
2012-08-08 18:55 ` [PATCH 1/3] " Mark Fasheh
2012-08-14 9:32 ` Jan Schmidt
2012-08-14 16:51 ` Mark Fasheh
2012-04-05 20:09 [PATCH 0/3] " Mark Fasheh
2012-04-05 20:09 ` [PATCH 1/3] " Mark Fasheh
2012-04-12 13:08 ` Jan Schmidt
2012-04-24 22:23 ` Mark Fasheh
2012-04-25 10:19 ` Jan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF700C5.5050406@giantdisaster.de \
--to=sbehrens@giantdisaster.de \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=list.btrfs@jan-o-sch.net \
--cc=mfasheh@suse.com \
--cc=mfasheh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).