From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net ([212.227.17.21]:51310 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752429AbdKUE6Z (ORCPT ); Mon, 20 Nov 2017 23:58:25 -0500 Subject: Re: bug? fstrim only trims unallocated space, not unused in bg's To: Chris Murphy Cc: Btrfs BTRFS References: <0f6c7514-1cf2-1d88-1307-c43f7642b525@gmx.com> <56401bb3-39fb-66d9-f77b-30e164bd8973@gmx.com> From: Qu Wenruo Message-ID: <4b7a0fae-ca96-7583-90d0-37cabc78849b@gmx.com> Date: Tue, 21 Nov 2017 12:58:05 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="K5iBSVglpOH2W9KIFCLFlv0PuSQr0w6q0" Sender: linux-btrfs-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --K5iBSVglpOH2W9KIFCLFlv0PuSQr0w6q0 Content-Type: multipart/mixed; boundary="OxTO9Aa7Q9uDJcwn3Jv2J0xONJs4XqJaE"; protected-headers="v1" From: Qu Wenruo To: Chris Murphy Cc: Btrfs BTRFS Message-ID: <4b7a0fae-ca96-7583-90d0-37cabc78849b@gmx.com> Subject: Re: bug? fstrim only trims unallocated space, not unused in bg's References: <0f6c7514-1cf2-1d88-1307-c43f7642b525@gmx.com> <56401bb3-39fb-66d9-f77b-30e164bd8973@gmx.com> In-Reply-To: --OxTO9Aa7Q9uDJcwn3Jv2J0xONJs4XqJaE Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2017=E5=B9=B411=E6=9C=8821=E6=97=A5 12:49, Chris Murphy wrote: > On Mon, Nov 20, 2017 at 9:43 PM, Qu Wenruo wro= te: >> >> >>> >>> Apply in addition to previous patch? Or apply to clean v4.14? >> >> On previous patch. >=20 > Refuses to apply with or without previous patch. >=20 > $ git apply -v ~/qufstrim3.patch > Checking patch fs/btrfs/extent-tree.c... > error: while searching for: > int dev_ret =3D 0; > int ret =3D 0; >=20 > /* > * try to trim all FS space, our block group may start from non-= zero. > */ >=20 > error: patch failed: fs/btrfs/extent-tree.c:10972 > error: fs/btrfs/extent-tree.c: patch does not apply >=20 Please try this branch. It's just previous patch and diff merged together and applied on v4.14 tag from torvalds. https://github.com/adam900710/linux/tree/tmp Thanks, Qu --OxTO9Aa7Q9uDJcwn3Jv2J0xONJs4XqJaE-- --K5iBSVglpOH2W9KIFCLFlv0PuSQr0w6q0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFLBAEBCAA1FiEELd9y5aWlW6idqkLhwj2R86El/qgFAloTsl0XHHF1d2VucnVv LmJ0cmZzQGdteC5jb20ACgkQwj2R86El/qg3UggAjwxdHvp/CKoaIsNSxAdCLgZm tTZJLzVjOwK/QCylB1mKgBOHmqIBBVg0+j+ORCs7gNxe6PT6KqaW9YkHWy92bhEl akypEGjmFiq4UUTW2WLXLM0FRfBmSJYAeOMpuU5C+QU1mz0mlyy0vn7EEYHjIFIp w6eVPCV5yg9IUJzAAcv4HacVUny1R14geaDoIiijSydCbKZy4NyGnEdi47QA802C 2FN9is4oKrKJbcmTA7js3nnraN3Luvnp89BKLXZp9g57IeHR0P+4TcuddYUjLP6K /KXMgsvXzOoMoRWy+2TP/AXiOhwXBAF4xqN9QMzYlIhrQgpXVhtPWo2kvYFBsw== =YJsC -----END PGP SIGNATURE----- --K5iBSVglpOH2W9KIFCLFlv0PuSQr0w6q0--