From: Josef Bacik <josef@toxicpanda.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>,
David Sterba <dsterba@suse.cz>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: About stale qgroup auto removal behavior change
Date: Tue, 4 Feb 2020 13:20:59 -0500 [thread overview]
Message-ID: <4cc678c3-1472-1432-7314-53e22129f757@toxicpanda.com> (raw)
In-Reply-To: <2dfbf017-9c82-1224-bdfc-73d0c0111e40@gmx.com>
On 2/3/20 7:37 PM, Qu Wenruo wrote:
> Hi David,
>
> This is the reminder of how we could handle the behavior change of
> staled qgroup auto removal.
>
> [PROBLEM]
> If btrfs has dropped one subvolume, it will not delete the level 0
> qgroup automatically, leaving the qgroup still hanging there, with all
> numbers set to 0.
> This needs manual user interaction to delete all those staled qgroups.
>
> [SOLUTIONS]
> There are several way to solve it, all with its advantage and disadvantage.
>
> - Auto remove them by default, and no way to keep the the staled qgroups
> Pro: Easy to implement (already submitted)
> Con: User has no choice to keep staled qgroups. But I could argue that
> no one sane would want to keep them anyway.
This should have been what was done in the first place. Nobody is using qgroups
right now anyway as they do not work, might as well do it the correct way now so
when they are in use we don't have to worry about it. Thanks,
Josef
next prev parent reply other threads:[~2020-02-04 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 0:37 About stale qgroup auto removal behavior change Qu Wenruo
2020-02-04 18:20 ` Josef Bacik [this message]
2020-02-05 1:00 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cc678c3-1472-1432-7314-53e22129f757@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox