From: Anand Jain <anand.jain@oracle.com>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, lists@colorremedies.com
Subject: Re: [PATCH v2 1/6] btrfs: Introduce a function to check if all chunks a OK for degraded rw mount
Date: Thu, 9 Mar 2017 02:26:51 +0800 [thread overview]
Message-ID: <4ccef095-36b7-3b1e-1baf-eec09562d52c@oracle.com> (raw)
In-Reply-To: <b698b207-bef6-4064-302d-784dda4dacd5@oracle.com>
>> Introduce a new function, btrfs_check_rw_degradable(), to check if all
>> chunks in btrfs is OK for degraded rw mount.
>>
>> It provides the new basis for accurate btrfs mount/remount and even
>> runtime degraded mount check other than old one-size-fit-all method.
Sorry for late response. But this patch has a bug (calls free
with the lock held) and fixed in this patch [1].
[1]
[PATCH] btrfs: fix btrfs_check_degradable() to free extent map
https://patchwork.kernel.org/patch/8868761/
the last version of this patch is here [2] and it did contain the
above fix [1] but it missed my sign-off and change commit log
update (sorry for that)
[2] http://www.spinics.net/lists/linux-btrfs/msg55038.html
Can you pls squash [1] to this patch.
With that.
> Looks good.
> Reviewed-by: Anand Jain <anand.jain@oracle.com>
While you are here, can you also consider..
-----
@@ -6843,7 +6843,7 @@ bool btrfs_check_rw_degradable(struct
btrfs_fs_info *fs_info,
int max_tolerated;
int i;
- map = (struct map_lookup *) em->bdev;
+ map = em->map_lookup;
max_tolerated =
btrfs_get_num_tolerated_disk_barrier_failures(
map->type);
------
Thanks, Anand
next prev parent reply other threads:[~2017-03-08 18:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 8:58 [PATCH v2 0/6] Chunk level degradable check Qu Wenruo
2017-03-06 8:58 ` [PATCH v2 1/6] btrfs: Introduce a function to check if all chunks a OK for degraded rw mount Qu Wenruo
2017-03-07 4:48 ` Anand Jain
2017-03-08 18:26 ` Anand Jain [this message]
2017-03-09 0:31 ` Qu Wenruo
2017-03-06 8:58 ` [PATCH v2 2/6] btrfs: Do chunk level rw degrade check at mount time Qu Wenruo
2017-03-06 8:58 ` [PATCH v2 3/6] btrfs: Do chunk level degradation check for remount Qu Wenruo
2017-03-06 8:58 ` [PATCH v2 4/6] btrfs: Allow barrier_all_devices to do chunk level device check Qu Wenruo
2017-03-07 4:48 ` Anand Jain
2017-03-07 5:36 ` Qu Wenruo
2017-03-07 6:55 ` Anand Jain
2017-03-07 7:08 ` Qu Wenruo
2017-03-07 8:07 ` Qu Wenruo
2017-03-06 8:58 ` [PATCH v2 5/6] btrfs: Cleanup num_tolerated_disk_barrier_failures Qu Wenruo
2017-03-06 8:58 ` [PATCH v2 6/6] btrfs: Enhance missing device kernel message Qu Wenruo
2017-03-07 4:47 ` Anand Jain
2017-03-06 18:49 ` [PATCH v2 0/6] Chunk level degradable check Dmitrii Tcvetkov
2017-03-07 0:36 ` Adam Borowski
2017-03-07 1:35 ` Qu Wenruo
2017-03-07 2:23 ` Adam Borowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ccef095-36b7-3b1e-1baf-eec09562d52c@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=lists@colorremedies.com \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).