linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikolay Borisov <nborisov@suse.com>
To: Andrea Gelmini <andrea.gelmini@gelma.net>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Proposal for more detail in scrub doc
Date: Tue, 27 Nov 2018 16:27:04 +0200	[thread overview]
Message-ID: <4ff8506f-8c25-a967-9cc6-45a11182c68a@suse.com> (raw)
In-Reply-To: <20181127141437.24744-1-andrea.gelmini@gelma.net>



On 27.11.18 г. 16:14 ч., Andrea Gelmini wrote:
> Wise words from Qu:
> https://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg82557.html
> ---
>  Documentation/btrfs-scrub.asciidoc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/btrfs-scrub.asciidoc b/Documentation/btrfs-scrub.asciidoc
> index 4c49269..1fc085c 100644
> --- a/Documentation/btrfs-scrub.asciidoc
> +++ b/Documentation/btrfs-scrub.asciidoc
> @@ -16,7 +16,8 @@ and metadata blocks from all devices and verify checksums. Automatically repair
>  corrupted blocks if there's a correct copy available.
>  
>  NOTE: Scrub is not a filesystem checker (fsck) and does not verify nor repair
> -structural damage in the filesystem.
> +structural damage in the filesystem. It only checks csum of data and tree blocks,
> +it doesn't ensure the content of tree blocks are OK.

I would rephrase this as:

"It only ensures that the checksum of given data/metadata blocks match
but doesn't guarantee that the contents themselves are consistent"

It sounds a bit more formal which I think is more appropriate for a man
page.


>  
>  The user is supposed to run it manually or via a periodic system service. The
>  recommended period is a month but could be less. The estimated device bandwidth
> 

  reply	other threads:[~2018-11-27 14:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-27 14:14 [PATCH] Proposal for more detail in scrub doc Andrea Gelmini
2018-11-27 14:27 ` Nikolay Borisov [this message]
2019-01-15 17:58 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ff8506f-8c25-a967-9cc6-45a11182c68a@suse.com \
    --to=nborisov@suse.com \
    --cc=andrea.gelmini@gelma.net \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).