From: Arne Jansen <sensille@gmx.net>
To: Liu Bo <liub.liubo@gmail.com>,
Stefan Behrens <sbehrens@giantdisaster.de>,
Jan Schmidt <list.btrfs@jan-o-sch.net>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] Btrfs: remove superblock writing after fatal error
Date: Thu, 02 Aug 2012 16:01:32 +0200 [thread overview]
Message-ID: <501A883C.3060003@gmx.net> (raw)
In-Reply-To: <20120802135719.GR17430@twin.jikos.cz>
On 02.08.2012 15:57, David Sterba wrote:
> On Thu, Aug 02, 2012 at 03:46:50PM +0200, Arne Jansen wrote:
>>> Anyway, for now, our error flag has only been stored in memory, so what
>>> about just keep it until we find a graceful way?
>>
>> Yeah, we need this patch to restore consistency. We can define a fixed
>> area on disk (e.g. behind the superblock) where we can write the flag
>> to without risking the superblock.
>
> Is it possible that sectors around the superblock are somehow damaged
> and unwritable that writing to them will fail as well? Ie. some safe
> distance from the superblock would be needed.
In about 1MB distance you're side-by-side with the superblock, so closer
to it might even be safer ;)
>
> david
next prev parent reply other threads:[~2012-08-02 14:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 11:45 [PATCH v2] Btrfs: remove superblock writing after fatal error Stefan Behrens
2012-08-01 12:02 ` Liu Bo
2012-08-01 13:07 ` Jan Schmidt
2012-08-01 13:31 ` Liu Bo
2012-08-01 13:56 ` Arne Jansen
2012-08-01 14:31 ` Stefan Behrens
2012-08-02 10:30 ` Stefan Behrens
2012-08-02 10:36 ` Liu Bo
2012-08-02 11:18 ` Arne Jansen
2012-08-02 11:34 ` Liu Bo
2012-08-02 11:40 ` Arne Jansen
2012-08-02 11:57 ` Liu Bo
2012-08-02 13:46 ` Arne Jansen
2012-08-02 13:57 ` David Sterba
2012-08-02 14:01 ` Arne Jansen [this message]
2012-08-02 14:28 ` Jan Schmidt
2012-08-03 3:20 ` Liu Bo
2012-08-03 4:59 ` Jan Schmidt
2012-08-02 15:06 ` cwillu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501A883C.3060003@gmx.net \
--to=sensille@gmx.net \
--cc=linux-btrfs@vger.kernel.org \
--cc=list.btrfs@jan-o-sch.net \
--cc=liub.liubo@gmail.com \
--cc=sbehrens@giantdisaster.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).