From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcsinet15.oracle.com ([148.87.113.117]:48288 "EHLO rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753222Ab2HPIza (ORCPT ); Thu, 16 Aug 2012 04:55:30 -0400 Message-ID: <502CB573.8000107@oracle.com> Date: Thu, 16 Aug 2012 16:55:15 +0800 From: Jie Liu MIME-Version: 1.0 To: Wang Sheng-Hui CC: sensille@gmx.net, chris.mason@fusionio.com, linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs-progs: add malloc check in transaction.h/btrfs_start_transaction References: <502CA7E6.8020004@gmail.com> <502CA945.602@gmx.net> In-Reply-To: <502CA945.602@gmx.net> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 08/16/12 16:03, Arne Jansen wrote: > On 16.08.2012 09:57, Wang Sheng-Hui wrote: >> For malloc may fail, we should check it before assign >> values to the fields of struct btrfs_trans_handle *h. >> >> Signed-off-by: Wang Sheng-Hui >> --- >> transaction.h | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/transaction.h b/transaction.h >> index a1070e0..d4e42a1 100644 >> --- a/transaction.h >> +++ b/transaction.h >> @@ -32,7 +32,12 @@ static inline struct btrfs_trans_handle * >> btrfs_start_transaction(struct btrfs_root *root, int num_blocks) >> { >> struct btrfs_fs_info *fs_info = root->fs_info; >> + Why move down a blank line? >> struct btrfs_trans_handle *h = malloc(sizeof(*h)); Skip a line here would looks a bit neat. >> + if (!h) { >> + BUG(); >> + return NULL; >> + } > a more simple way would be to write > BUG_ON(!h); > >> >> BUG_ON(root->commit_root); >> BUG_ON(fs_info->running_transaction); > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html