From: Arne Jansen <sensille@gmx.net>
To: Wang Sheng-Hui <shhuiw@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: trivial code style fix in root-tree.c
Date: Thu, 16 Aug 2012 15:23:28 +0200 [thread overview]
Message-ID: <502CF450.50405@gmx.net> (raw)
In-Reply-To: <502CF2F0.7020601@gmail.com>
On 16.08.2012 15:17, Wang Sheng-Hui wrote:
> Add code indent to the bad styled statements.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> ---
> root-tree.c | 10 ++++------
> 1 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/root-tree.c b/root-tree.c
> index 782472c..39cfef6 100644
> --- a/root-tree.c
> +++ b/root-tree.c
> @@ -182,12 +182,10 @@ int btrfs_del_root(struct btrfs_trans_handle *trans, struct btrfs_root *root,
> if (ret < 0)
> goto out;
> if (ret) {
> -btrfs_print_leaf(root, path->nodes[0]);
> -printk("failed to del %llu %u %llu\n",
> - (unsigned long long)key->objectid,
> - key->type,
> - (unsigned long long)key->offset);
> -
I guess Alexander intentionally put in the bad indentation
to remind him to remove this code before submitting the
patch :)
> + btrfs_print_leaf(root, path->nodes[0]);
> + printk("failed to del %llu %u %llu\n",
> + (unsigned long long)key->objectid, key->type,
> + (unsigned long long)key->offset);
> }
> BUG_ON(ret != 0);
> leaf = path->nodes[0];
next prev parent reply other threads:[~2012-08-16 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 13:17 [PATCH] btrfs-progs: trivial code style fix in root-tree.c Wang Sheng-Hui
2012-08-16 13:23 ` Arne Jansen [this message]
2012-08-16 13:26 ` Wang Sheng-Hui
2012-08-16 13:30 ` Arne Jansen
2012-08-16 14:25 ` Wang Sheng-Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502CF450.50405@gmx.net \
--to=sensille@gmx.net \
--cc=linux-btrfs@vger.kernel.org \
--cc=shhuiw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).