From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:44711 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932088Ab2HPN0m (ORCPT ); Thu, 16 Aug 2012 09:26:42 -0400 Received: by pbbrr13 with SMTP id rr13so1589432pbb.19 for ; Thu, 16 Aug 2012 06:26:41 -0700 (PDT) Message-ID: <502CF50C.9090006@gmail.com> Date: Thu, 16 Aug 2012 21:26:36 +0800 From: Wang Sheng-Hui MIME-Version: 1.0 To: Arne Jansen CC: linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs-progs: trivial code style fix in root-tree.c References: <502CF2F0.7020601@gmail.com> <502CF450.50405@gmx.net> In-Reply-To: <502CF450.50405@gmx.net> Content-Type: text/plain; charset=UTF-8 Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 2012年08月16日 21:23, Arne Jansen wrote: > On 16.08.2012 15:17, Wang Sheng-Hui wrote: >> Add code indent to the bad styled statements. >> >> Signed-off-by: Wang Sheng-Hui >> --- >> root-tree.c | 10 ++++------ >> 1 files changed, 4 insertions(+), 6 deletions(-) >> >> diff --git a/root-tree.c b/root-tree.c >> index 782472c..39cfef6 100644 >> --- a/root-tree.c >> +++ b/root-tree.c >> @@ -182,12 +182,10 @@ int btrfs_del_root(struct btrfs_trans_handle *trans, struct btrfs_root *root, >> if (ret < 0) >> goto out; >> if (ret) { >> -btrfs_print_leaf(root, path->nodes[0]); >> -printk("failed to del %llu %u %llu\n", >> - (unsigned long long)key->objectid, >> - key->type, >> - (unsigned long long)key->offset); >> - > > I guess Alexander intentionally put in the bad indentation > to remind him to remove this code before submitting the > patch :) > >> + btrfs_print_leaf(root, path->nodes[0]); >> + printk("failed to del %llu %u %llu\n", >> + (unsigned long long)key->objectid, key->type, >> + (unsigned long long)key->offset); >> } When I saw the BUG_ON, I wonder do we still need the above branch statement. It looks just to be helpful for debug - give out some info, right? >> BUG_ON(ret != 0); >> leaf = path->nodes[0]; >