From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cn.fujitsu.com ([222.73.24.84]:29977 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750986Ab2H2GVY (ORCPT ); Wed, 29 Aug 2012 02:21:24 -0400 Message-ID: <503DB4B4.3080001@cn.fujitsu.com> Date: Wed, 29 Aug 2012 14:20:36 +0800 From: Miao Xie Reply-To: miaox@cn.fujitsu.com MIME-Version: 1.0 To: Stefan Behrens CC: Linux Btrfs List , David Sterba Subject: Re: [BUG] btrfs dev del causes 'possible circular locking dependency detected' References: <5023D916.6030707@giantdisaster.de> <20120809160157.GF17430@twin.jikos.cz> <5023E8DC.50702@giantdisaster.de> In-Reply-To: <5023E8DC.50702@giantdisaster.de> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Thu, 09 Aug 2012 18:44:12 +0200, Stefan Behrens wrote: > On Thu, 9 Aug 2012 18:01:57 +0200, David Sterba wrote: >> On Thu, Aug 09, 2012 at 05:36:54PM +0200, Stefan Behrens wrote: >>> Aug 9 16:02:21 qvarne kernel: [ 543.479460] -> #2 (&fs_info->cleaner_mutex){+.+...}: >>> Aug 9 16:02:21 qvarne kernel: [ 543.541341] [] lock_acquire+0x95/0x150 >>> Aug 9 16:02:21 qvarne kernel: [ 543.612269] [] mutex_lock_nested+0x71/0x360 >>> Aug 9 16:02:21 qvarne kernel: [ 543.688396] [] btrfs_commit_super+0x1f/0x100 [btrfs] >>> Aug 9 16:02:21 qvarne kernel: [ 543.773884] [] close_ctree+0x318/0x360 [btrfs] >>> Aug 9 16:02:21 qvarne kernel: [ 543.853132] [] btrfs_put_super+0x14/0x20 [btrfs] >>> Aug 9 16:02:21 qvarne kernel: [ 543.934459] [] generic_shutdown_super+0x5d/0xf0 >>> Aug 9 16:02:21 qvarne kernel: [ 544.014747] [] kill_anon_super+0x11/0x20 >>> Aug 9 16:02:21 qvarne kernel: [ 544.087756] [] btrfs_kill_super+0x15/0x90 [btrfs] >>> Aug 9 16:02:21 qvarne kernel: [ 544.170124] [] deactivate_locked_super+0x3d/0x70 >>> Aug 9 16:02:21 qvarne kernel: [ 544.251452] [] deactivate_super+0x49/0x70 >>> Aug 9 16:02:21 qvarne kernel: [ 544.325500] [] mntput_no_expire+0xfe/0x160 >>> Aug 9 16:02:21 qvarne kernel: [ 544.400588] [] sys_umount+0x69/0x3a0 >>> Aug 9 16:02:21 qvarne kernel: [ 544.469435] [] system_call_fastpath+0x16/0x1b >>> Aug 9 16:02:21 qvarne kernel: [ 544.547644] >>> Aug 9 16:02:21 qvarne kernel: [ 544.547644] -> #1 (&type->s_umount_key#31){+++++.}: >>> Aug 9 16:02:21 qvarne kernel: [ 544.608588] [] lock_acquire+0x95/0x150 >>> Aug 9 16:02:21 qvarne kernel: [ 544.679516] [] down_read+0x47/0x8e >>> Aug 9 16:02:21 qvarne kernel: [ 544.746283] [] writeback_inodes_sb_nr_if_idle+0x38/0x60 >> >> this matches the "umount vs cleaner vs writeback_idle" deadlock pattern, Miao sent >> patches some time ago, I've tested them succesfully, but they're not >> merged upstream. >> >> http://thread.gmane.org/gmane.linux.file-systems/63900 >> vfs: re-implement writeback_inodes_sb(_nr)_if_idle() and rename them >> >> http://thread.gmane.org/gmane.comp.file-systems.btrfs/17040 >> [PATCH 2/2] Btrfs: flush all the dirty pages if try_to_writeback_inodes_sb_nr() fails > > After applying these two patches from Miao Xie, logcheck does not > complain anymore. > > Could we start a second attempt to add these VFS, ext4 and btrfs changes? > Sorry to reply late. I'm busy to debug some problems recently. I have re-sent this patchset today, and hope it will be received as soon as possible. Thanks Miao