From: Miao Xie <miaox@cn.fujitsu.com>
To: Linux Btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] Btrfs: cleanup duplicated division functions
Date: Mon, 17 Sep 2012 10:21:00 +0800 [thread overview]
Message-ID: <5056890C.5020208@cn.fujitsu.com> (raw)
In-Reply-To: <20120914135418.GM17430@twin.jikos.cz>
On fri, 14 Sep 2012 15:54:18 +0200, David Sterba wrote:
> On Thu, Sep 13, 2012 at 06:51:36PM +0800, Miao Xie wrote:
>> div_factor{_fine} has been implemented for two times, cleanup it.
>> And I move them into a independent file named math.h because they are
>> common math functions.
>
> You removed the sanity checks:
>
> - if (factor <= 0)
> - return 0;
> - if (factor >= 100)
> - return num;
As inline functions, they should not contain complex checks, the caller should
make sure the parameters are right. I think.
> in new version. And I don't think it's necessary to add an extra include
> with a rather generic name and trivial code. A separate .h/.c with
> non-filesystem related support code like this looks more suitable.
>
> Do you intend to use the functions out of extent-tree.c ?
They are used in both extent-tree.c and volumes.c from the outset, but they
were implemented in these two files severally.
next prev parent reply other threads:[~2012-09-17 2:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 10:51 [PATCH 1/2] Btrfs: cleanup duplicated division functions Miao Xie
2012-09-14 13:54 ` David Sterba
2012-09-17 2:21 ` Miao Xie [this message]
2012-09-17 12:07 ` Ilya Dryomov
2012-09-17 16:31 ` David Sterba
2012-09-18 3:53 ` Miao Xie
2012-09-20 2:57 ` [PATCH V2 " Miao Xie
2012-09-20 13:28 ` David Sterba
2012-09-21 8:26 ` Miao Xie
2012-09-21 9:07 ` [PATCH V3 " Miao Xie
2012-09-21 15:24 ` David Sterba
2012-09-23 9:54 ` Miao Xie
2012-09-24 16:33 ` David Sterba
2012-09-23 11:49 ` Ilya Dryomov
2012-09-24 2:05 ` Miao Xie
2012-09-24 16:47 ` David Sterba
2012-09-24 18:42 ` Ilya Dryomov
2012-09-25 10:24 ` Miao Xie
2012-09-27 10:15 ` Miao Xie
2012-09-27 10:19 ` [PATCH V4 " Miao Xie
2012-09-27 16:56 ` Ilya Dryomov
2012-09-28 1:30 ` Miao Xie
2012-09-28 1:49 ` [PATCH V5 " Miao Xie
2012-09-28 10:09 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5056890C.5020208@cn.fujitsu.com \
--to=miaox@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).