From: Miao Xie <miaox@cn.fujitsu.com>
To: Anand Jain <Anand.Jain@oracle.com>
Cc: Linux Btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH V3 4/7] Btrfs-progs: fix wrong way to check if the root item contains otime and uuid
Date: Tue, 18 Sep 2012 14:11:36 +0800 [thread overview]
Message-ID: <50581098.7090309@cn.fujitsu.com> (raw)
In-Reply-To: <50580D1C.9020303@oracle.com>
On Tue, 18 Sep 2012 13:56:44 +0800, Anand Jain wrote:
>
>
>> - if(ri->generation == ri->generation_v2) {
>> + if(sh->len == sizeof(struct btrfs_root_item)) {
>> t = ri->otime.sec;
>
> This looks fine now but should this work when we
> move to v3 and still have access to v2 introduced
> members.?
>
> ker cli
> v3 v2 v2 introduced members are unnecessarily blocked
> v2 v3 --as above--
No.
I will update my patch to fix this problem.
Thanks
Miao
next prev parent reply other threads:[~2012-09-18 6:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 10:48 [PATCH V3 0/7 ] Btrfs-progs: enhance btrfs subvol list only to show read-only snapshots Miao Xie
2012-09-06 10:48 ` [PATCH V3 1/7] Btrfs-progs: move the function declarations to a new head file Miao Xie
2012-09-06 10:49 ` [PATCH V3 2/7] Btrfs-progs: fix compile warning of implicit declaration, of "list_snapshots" Miao Xie
2012-09-06 10:49 ` [PATCH V3 3/7] Btrfs-progs: fix wrong usage of btrfs subvolume list command Miao Xie
2012-09-06 10:50 ` [PATCH V3 4/7] Btrfs-progs: fix wrong way to check if the root item contains otime and uuid Miao Xie
2012-09-18 5:56 ` Anand Jain
2012-09-18 6:11 ` Miao Xie [this message]
2012-09-06 10:50 ` [PATCH V3 5/7] Btrfs-progs: restructure list_subvolumes Miao Xie
2012-09-06 10:50 ` [PATCH V3 6/7] Btrfs-progs: enhance btrfs subvol list only to show read-only snapshots Miao Xie
2012-09-06 10:50 ` [PATCH V3 7/7] Btrfs-progs: update the manpage entries for the btrfs, subvolume list Miao Xie
2012-09-06 10:57 ` [PATCH V3 1/7] Btrfs-progs: move the function declarations to a new head file Miao Xie
2012-09-06 10:59 ` [PATCH V3 7/7] Btrfs-progs: update the manpage entries for the btrfs subvolume list Miao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50581098.7090309@cn.fujitsu.com \
--to=miaox@cn.fujitsu.com \
--cc=Anand.Jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).