linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 4/4] Btrfs: tivial cleanup: add space between = and the rest code
@ 2012-09-24  0:47 Wang Sheng-Hui
  2012-09-24 13:15 ` David Sterba
  0 siblings, 1 reply; 3+ messages in thread
From: Wang Sheng-Hui @ 2012-09-24  0:47 UTC (permalink / raw)
  To: linux-btrfs, trivial

trivial code cleanup.

Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
---
 fs/btrfs/transaction.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
index 675d813..3279df2 100644
--- a/fs/btrfs/transaction.c
+++ b/fs/btrfs/transaction.c
@@ -1619,7 +1619,7 @@ int btrfs_clean_old_snapshots(struct btrfs_root *root)
 		    BTRFS_MIXED_BACKREF_REV)
 			ret = btrfs_drop_snapshot(root, NULL, 0, 0);
 		else
-			ret =btrfs_drop_snapshot(root, NULL, 1, 0);
+			ret = btrfs_drop_snapshot(root, NULL, 1, 0);
 		BUG_ON(ret < 0);
 	}
 	return 0;
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 4/4] Btrfs: tivial cleanup: add space between = and the rest code
  2012-09-24  0:47 [PATCH 4/4] Btrfs: tivial cleanup: add space between = and the rest code Wang Sheng-Hui
@ 2012-09-24 13:15 ` David Sterba
  2012-09-25  0:01   ` Wang Sheng-Hui
  0 siblings, 1 reply; 3+ messages in thread
From: David Sterba @ 2012-09-24 13:15 UTC (permalink / raw)
  To: Wang Sheng-Hui; +Cc: linux-btrfs, trivial

On Mon, Sep 24, 2012 at 08:47:33AM +0800, Wang Sheng-Hui wrote:
> trivial code cleanup.

> -			ret =btrfs_drop_snapshot(root, NULL, 1, 0);
> +			ret = btrfs_drop_snapshot(root, NULL, 1, 0);

Sorry but this is too trivial.

Unless it really bugs you when you're going through code, I don't think
that cleanups at this level are necessary. Reading through commit
history of some code via 'git blame' and seeing such cleanups is not
welcome.

I have a patchet in testing that updates a few things around snapshot
cleaning and this line will get fixed, so it'll not stay forever.

david

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 4/4] Btrfs: tivial cleanup: add space between = and the rest code
  2012-09-24 13:15 ` David Sterba
@ 2012-09-25  0:01   ` Wang Sheng-Hui
  0 siblings, 0 replies; 3+ messages in thread
From: Wang Sheng-Hui @ 2012-09-25  0:01 UTC (permalink / raw)
  To: linux-btrfs, trivial

On 2012年09月24日 21:15, David Sterba wrote:
> On Mon, Sep 24, 2012 at 08:47:33AM +0800, Wang Sheng-Hui wrote:
>> trivial code cleanup.
> 
>> -			ret =btrfs_drop_snapshot(root, NULL, 1, 0);
>> +			ret = btrfs_drop_snapshot(root, NULL, 1, 0);
> 
> Sorry but this is too trivial.
> 
> Unless it really bugs you when you're going through code, I don't think
> that cleanups at this level are necessary. Reading through commit
> history of some code via 'git blame' and seeing such cleanups is not
> welcome.
> 

Got it. Thanks,

> I have a patchet in testing that updates a few things around snapshot
> cleaning and this line will get fixed, so it'll not stay forever.
> 
> david


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-09-25  0:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-24  0:47 [PATCH 4/4] Btrfs: tivial cleanup: add space between = and the rest code Wang Sheng-Hui
2012-09-24 13:15 ` David Sterba
2012-09-25  0:01   ` Wang Sheng-Hui

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).