linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ching <lsching17@gmail.com>
To: Josef Bacik <jbacik@fusionio.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: do not async metadata csums if we have hardware crc32c
Date: Tue, 25 Sep 2012 19:40:17 +0800	[thread overview]
Message-ID: <50619821.60609@gmail.com> (raw)
In-Reply-To: <20120925105154.GS14582@twin.jikos.cz>

On 09/25/2012 06:51 PM, David Sterba wrote:
> On Mon, Sep 24, 2012 at 11:03:49PM +0200, David Sterba wrote:
>> Could you please put the check into a separate helper
> Please note that checksum will become a variable per-filesystem
> property, stored within the superblock, so the helper should be passed a
> fs_info pointer.
>
> thanks,
> david
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

How about enhancing the "*thread_pool=/number" mount option instead?

thread_pool=n     enable threadpool/**/for compression and checksum, MAY improve bandwidth/*
*/thread_pool=0     disable threadpool for compression and checksum, MIGHT reduce latency
thread_pool=-1 or not provided    automatically managed (current behaviour and default choice)


This should allow user to tradeoff between latency and bandwidth, furthermore, you do not need to assume that btrfs may use crc32c algorithm only forever.




/*

  reply	other threads:[~2012-09-25 11:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-24 18:11 [PATCH] Btrfs: do not async metadata csums if we have hardware crc32c Josef Bacik
2012-09-24 18:19 ` Arne Jansen
2012-09-24 18:33   ` Josef Bacik
2012-09-24 18:58   ` Chris Mason
2012-09-24 21:03 ` David Sterba
2012-09-25 10:51   ` David Sterba
2012-09-25 11:40     ` ching [this message]
2012-09-25 12:55       ` David Sterba
2012-09-25 11:54     ` ching

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50619821.60609@gmail.com \
    --to=lsching17@gmail.com \
    --cc=jbacik@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).