From: Arne Jansen <sensille@gmx.net>
To: Josef Bacik <jbacik@fusionio.com>
Cc: David Sterba <dave@jikos.cz>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: try to avoid doing a search in btrfs_next_leaf
Date: Tue, 02 Oct 2012 17:30:07 +0200 [thread overview]
Message-ID: <506B087F.7030006@gmx.net> (raw)
In-Reply-To: <20121002152731.GF2370@localhost.localdomain>
On 02.10.2012 17:27, Josef Bacik wrote:
> On Tue, Oct 02, 2012 at 09:05:43AM -0600, David Sterba wrote:
>> On Tue, Oct 02, 2012 at 10:32:32AM -0400, Josef Bacik wrote:
>>> On Tue, Oct 02, 2012 at 08:25:38AM -0600, David Sterba wrote:
>>>> Hi,
>>>>
>>>> On Mon, Sep 24, 2012 at 04:02:59PM -0400, Josef Bacik wrote:
>>>>> --- a/fs/btrfs/ctree.h
>>>>> +++ b/fs/btrfs/ctree.h
>>>>> @@ -571,6 +571,7 @@ struct btrfs_path {
>>>>> unsigned int skip_locking:1;
>>>>> unsigned int leave_spinning:1;
>>>>> unsigned int search_commit_root:1;
>>>>> + unsigned int shecantgoanyfarthercapt:1;
>>>>
>>>> so you did not make it to LWN's quote of the week, can you please rename
>>>> it to something sensible?
>>>>
>>>
>>> I don't see what's unsensible about it.
>>
>> Itsfunnybuthardtoreadanddoesnothelpunderstandingthecodewhereitsused.
>>
>
> Idisagreeithinkithelpstremendouslywiththeunderstandingofthecode,youcantgoanyfarther,butfineineedotaddacommenttobtrfs_next_leafanywaysoi'llnameitsomethingelse,anysuggestions?
>
wecantgoanyfarther
> Josef
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-10-02 15:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 20:02 [PATCH] Btrfs: try to avoid doing a search in btrfs_next_leaf Josef Bacik
2012-09-30 11:28 ` Alex Lyakas
2012-10-01 16:45 ` Josef Bacik
2012-10-02 8:17 ` Alex Lyakas
2012-10-02 14:25 ` David Sterba
2012-10-02 14:32 ` Josef Bacik
2012-10-02 15:05 ` David Sterba
2012-10-02 15:27 ` Josef Bacik
2012-10-02 15:30 ` Arne Jansen [this message]
2012-10-03 12:57 ` Alex Lyakas
2012-10-03 13:32 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506B087F.7030006@gmx.net \
--to=sensille@gmx.net \
--cc=dave@jikos.cz \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).