From: Wade Cline <clinew@linux.vnet.ibm.com>
To: Josef Bacik <jbacik@fusionio.com>
Cc: linux-btrfs@vger.kernel.org,
"cmm@linux.vnet.ibm.com" <cmm@linux.vnet.ibm.com>
Subject: Re: [RFC] [PATCH] Btrfs: rework can_nocow_odirect
Date: Tue, 02 Oct 2012 18:00:28 -0700 [thread overview]
Message-ID: <506B8E2C.7070107@linux.vnet.ibm.com> (raw)
In-Reply-To: <1349118014-6319-1-git-send-email-jbacik@fusionio.com>
Hi Josef,
This patch is causing fragmentation with O_DIRECT on preallocated extents located
-after- the first write to the preallocated extent. This happens regardless of
nodatacow/autodefrag mount options.
Thank you,
Wade
On 10/01/2012 12:00 PM, Josef Bacik wrote:
> I need everybody to go over this with a fine toothed comb since it is a pretty
> big change. I think it is right and it seems to come out right, but if it's not
> it will mean we screw up O_DIRECT on snapshotted files with preallocated
> extents, so please, make sure it is correct :).
prev parent reply other threads:[~2012-10-03 1:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 19:00 [RFC] [PATCH] Btrfs: rework can_nocow_odirect Josef Bacik
2012-10-03 1:00 ` Wade Cline [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506B8E2C.7070107@linux.vnet.ibm.com \
--to=clinew@linux.vnet.ibm.com \
--cc=cmm@linux.vnet.ibm.com \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).