From: Miao Xie <miaox@cn.fujitsu.com>
To: Anand jain <Anand.Jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/4] filter snapshot(s) by its parent uuid
Date: Fri, 19 Oct 2012 15:38:11 +0800 [thread overview]
Message-ID: <50810363.1090304@cn.fujitsu.com> (raw)
In-Reply-To: <1350627837-27639-1-git-send-email-Anand.Jain@oracle.com>
On fri, 19 Oct 2012 14:23:53 +0800, Anand jain wrote:
> From: Anand Jain <anand.jain@oracle.com>
>
> This set of patch will make
> btrfs su list -s <subvol>
> to list only snapshot(s) of the given subvol.
>
> before:
> btrfs su list -s /btrfs/sv1
> <nothing>
> btrfs su list -s /btrfs
> ID 258 gen 6 cgen 6 top level 5 otime 2012-10-18 17:01:56 uuid f648cdda-4efa-6f45-bd6b-041a8ae1538e path ss1
> ID 260 gen 8 cgen 8 top level 5 otime 2012-10-18 17:02:20 uuid ea8fdf85-8d3f-8946-b3af-ede510cdcf19 path ss2
> ID 261 gen 9 cgen 9 top level 5 otime 2012-10-19 13:37:42 uuid 44560e56-3879-2146-8b24-e9048871892f path ss3
>
> with this patch:
> btrfs su list -s /btrfs/sv1
> ID 258 gen 6 cgen 6 top level 5 otime 2012-10-18 17:01:56 uuid f648cdda-4efa-6f45-bd6b-041a8ae1538e path ss1
> ID 261 gen 9 cgen 9 top level 5 otime 2012-10-19 13:37:42 uuid 44560e56-3879-2146-8b24-e9048871892f path ss3
Though the function implemented by your patch is very useful, you change the semantic of "-s",
I think it is not allowed, or the programs that use "btrfs us list -s" may fail.
I think it is better to add a new option.
Thanks
Miao
>
> btrfs su list -s /btrfs
> ID 258 gen 6 cgen 6 top level 5 otime 2012-10-18 17:01:56 uuid f648cdda-4efa-6f45-bd6b-041a8ae1538e path ss1
> ID 260 gen 8 cgen 8 top level 5 otime 2012-10-18 17:02:20 uuid ea8fdf85-8d3f-8946-b3af-ede510cdcf19 path ss2
> ID 261 gen 9 cgen 9 top level 5 otime 2012-10-19 13:37:42 uuid 44560e56-3879-2146-8b24-e9048871892f path ss3
>
> Anand Jain (4):
> Btrfs-progs: provide method to check if filter is set
> Btrfs-progs: fix irrelevant string in the subvol path
> Btrfs-progs: add method to filter snapshots by parent uuid
> Btrfs-progs: list only snapshots of the given subvol
>
> btrfs-list.c | 17 +++++++++++++++++
> btrfs-list.h | 3 +++
> cmds-subvolume.c | 39 +++++++++++++++++++++++++++++++++++++--
> 3 files changed, 57 insertions(+), 2 deletions(-)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-10-19 7:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 6:23 [PATCH 0/4] filter snapshot(s) by its parent uuid Anand jain
2012-10-19 6:23 ` [PATCH 1/4] Btrfs-progs: provide method to check if filter is set Anand jain
2012-10-19 6:23 ` [PATCH 2/4] Btrfs-progs: fix irrelevant string in the subvol path Anand jain
2012-10-19 8:59 ` Miao Xie
2012-10-19 6:23 ` [PATCH 3/4] Btrfs-progs: add method to filter snapshots by parent uuid Anand jain
2012-10-19 6:23 ` [PATCH 4/4] Btrfs-progs: list only snapshots of the given subvol Anand jain
2012-10-19 7:38 ` Miao Xie [this message]
2012-10-19 8:37 ` [PATCH 0/4] filter snapshot(s) by its parent uuid Rory Campbell-Lange
2012-10-22 12:34 ` Lenz Grimmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50810363.1090304@cn.fujitsu.com \
--to=miaox@cn.fujitsu.com \
--cc=Anand.Jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).