From: Liu Bo <bo.li.liu@oracle.com>
To: Jan Schmidt <list.btrfs@jan-o-sch.net>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 4/4] Btrfs: cleanup unused arguments
Date: Fri, 19 Oct 2012 20:44:55 +0800 [thread overview]
Message-ID: <50814B47.1020306@oracle.com> (raw)
In-Reply-To: <5081443B.5060706@jan-o-sch.net>
On 10/19/2012 08:14 PM, Jan Schmidt wrote:
> Hi liubo,
>
> Patches 3 and 4 are looking good. I'm still trying to sort out on the other two,
> as I cannot reproduce your bug with your script, unfortunately.
>
> After applying all 4 patches, the result doesn't compile, here:
>
> fs/btrfs/ctree.c: In function 'balance_level':
> fs/btrfs/ctree.c:1799: warning: passing argument 3 of
> 'tree_mod_log_set_node_key' makes integer from pointer without a cast
> fs/btrfs/ctree.c:774: note: expected 'int' but argument is of type 'struct
> btrfs_disk_key *'
> fs/btrfs/ctree.c:1799: error: too many arguments to function
> 'tree_mod_log_set_node_key'
> fs/btrfs/ctree.c:1844: warning: passing argument 3 of
> 'tree_mod_log_set_node_key' makes integer from pointer without a cast
> fs/btrfs/ctree.c:774: note: expected 'int' but argument is of type 'struct
> btrfs_disk_key *'
> fs/btrfs/ctree.c:1844: error: too many arguments to function
> 'tree_mod_log_set_node_key'
> fs/btrfs/ctree.c: In function 'push_nodes_for_insert':
> fs/btrfs/ctree.c:1943: warning: passing argument 3 of
> 'tree_mod_log_set_node_key' makes integer from pointer without a cast
> fs/btrfs/ctree.c:774: note: expected 'int' but argument is of type 'struct
> btrfs_disk_key *'
> fs/btrfs/ctree.c:1943: error: too many arguments to function
> 'tree_mod_log_set_node_key'
> fs/btrfs/ctree.c:1996: warning: passing argument 3 of
> 'tree_mod_log_set_node_key' makes integer from pointer without a cast
> fs/btrfs/ctree.c:774: note: expected 'int' but argument is of type 'struct
> btrfs_disk_key *'
> fs/btrfs/ctree.c:1996: error: too many arguments to function
> 'tree_mod_log_set_node_key'
> fs/btrfs/ctree.c: In function 'fixup_low_keys':
> fs/btrfs/ctree.c:2880: warning: passing argument 3 of
> 'tree_mod_log_set_node_key' makes integer from pointer without a cast
> fs/btrfs/ctree.c:774: note: expected 'int' but argument is of type 'struct
> btrfs_disk_key *'
> fs/btrfs/ctree.c:2880: error: too many arguments to function
> 'tree_mod_log_set_node_key'
> CC [M] fs/btrfs/sysfs.o
> make[2]: *** [fs/btrfs/ctree.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [fs/btrfs] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [fs] Error 2
>
oh, I'm so sorry, I forgot to format new patches and sent the wrong version.
Sorry for the trouble.
thanks,
liubo
> -Jan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2012-10-19 12:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 9:50 [PATCH 1/4] Btrfs: MOD_LOG_KEY_REMOVE_WHILE_MOVING never change node's nritems Liu Bo
2012-10-19 9:50 ` [PATCH 2/4] Btrfs: reorder tree mod log operations in deleting a pointer Liu Bo
2012-10-19 9:50 ` [PATCH 3/4] Btrfs: kill unnecessary arguments in del_ptr Liu Bo
2012-10-19 9:50 ` [PATCH 4/4] Btrfs: cleanup unused arguments Liu Bo
2012-10-19 12:14 ` Jan Schmidt
2012-10-19 12:44 ` Liu Bo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50814B47.1020306@oracle.com \
--to=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=list.btrfs@jan-o-sch.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).