From: Liu Bo <bo.li.liu@oracle.com>
To: David Sterba <dave@jikos.cz>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] Btrfs: make snapshot-aware defrag as a mount option
Date: Wed, 31 Oct 2012 08:34:38 +0800 [thread overview]
Message-ID: <5090721E.2090806@oracle.com> (raw)
In-Reply-To: <20121030233146.GB3102@twin.jikos.cz>
On 10/31/2012 07:31 AM, David Sterba wrote:
> On Sat, Oct 27, 2012 at 06:28:41PM +0800, Liu Bo wrote:
>> This feature works on our crucial write endio path, so if we've got
>> lots of fragments to process, it will be kind of a disaster to the
>> performance, so I make such a change.
>>
>> One can benifit from it while mounting with '-o snap_aware_defrag'.
>
> I vote for a more fine grained control over this feature, ie. via
> 'btrfs fi defrag', off by default (current behaviour). The defrag ioctl
> is the only place that actually calls set_extent_defrag, so this will
> not affect normal operation and is fully in hands of the user who runs
> defrag.
>
Besides 'btrfs fi defrag', mounting with autodefrag may also do the same thing.
But controlling by 'btrfs fi defrag' can actually be a good idea.
thanks,
liubo
> Do you have a usecase for setting it through the mount option?
>
> thanks,
> david
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-10-31 0:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 10:28 [PATCH 1/2 v4] Btrfs: snapshot-aware defrag Liu Bo
2012-10-27 10:28 ` [PATCH 2/2] Btrfs: make snapshot-aware defrag as a mount option Liu Bo
2012-10-30 23:31 ` David Sterba
2012-10-31 0:34 ` Liu Bo [this message]
2012-10-31 0:44 ` David Sterba
2012-10-31 13:31 ` Liu Bo
2012-11-01 14:43 ` Chris Mason
2012-11-01 15:49 ` Liu Bo
2012-10-29 20:06 ` [PATCH 1/2 v4] Btrfs: snapshot-aware defrag Mitch Harder
2012-10-30 1:20 ` Liu Bo
2012-10-30 20:59 ` Mitch Harder
2012-10-31 12:13 ` Itaru Kitayama
2012-10-31 12:55 ` Liu Bo
2012-11-01 11:08 ` Itaru Kitayama
2012-11-01 11:21 ` Liu Bo
2012-11-01 14:05 ` Itaru Kitayama
2012-11-01 16:01 ` Liu Bo
[not found] ` <CANW9uyt9qE9384WnQq5ggZ2hb-DbahZe8KY5-WXRFSKTiedekg@mail.gmail.com>
2012-11-26 10:30 ` Liu Bo
2012-12-12 19:37 ` Mitch Harder
2012-12-13 1:28 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5090721E.2090806@oracle.com \
--to=bo.li.liu@oracle.com \
--cc=dave@jikos.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).