From: Goffredo Baroncelli <kreijack@gmail.com>
To: Gabriel <g2p.code@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH][BTRFS-PROGS] Enhance btrfs fi df
Date: Fri, 02 Nov 2012 20:31:56 +0100 [thread overview]
Message-ID: <50941FAC.1010803@gmail.com> (raw)
In-Reply-To: <k715i0$7go$1@ger.gmane.org>
On 11/02/2012 08:05 PM, Gabriel wrote:
> On Fri, 02 Nov 2012 13:02:32 +0100, Goffredo Baroncelli wrote:
>> On 2012-11-02 12:18, Martin Steigerwald wrote:
>>> Metadata, DUP is displayed as 3,50GB on the device level and as 1,75GB
>>> in total. I understand the logic behind this, but this could be a bit
>>> confusing.
>>>
>>> But it makes sense: Showing real allocation on device level makes
>>> sense,
>>> cause thats what really allocated on disk. Total makes some sense,
>>> cause thats what is being used from the tree by BTRFS.
>>
>> Yes, me too. At the first I was confused when you noticed this
>> discrepancy. So I have to admit that it is not so obvious to understand.
>> However we didn't find any way to make it more clear...
>>
>>> It still looks confusing at first…
>> We could use "Chunk(s) capacity" instead of total/size ? I would like an
>> opinion from a "english people" point of view..
>
> This is easy to fix, here's a mockup:
>
> Metadata,DUP: Size: 1.75GB ×2, Used: 627.84MB ×2
> /dev/dm-0 3.50GB
>
> Data Metadata Metadata System System
> Single Single DUP Single DUP Unallocated
>
> /dev/dm-16 1.31TB 8.00MB 56.00GB 4.00MB 16.00MB 0.00
> ====== ======== =========== ====== =========== ===========
> Total 1.31TB 8.00MB 28.00GB ×2 4.00MB 8.00MB ×2 0.00
> Used 1.31TB 0.00 5.65GB ×2 0.00 152.00KB ×2
Nice idea. Even tough I like the opposite:
Data Metadata Metadata System System
Single Single DUP Single DUP Unallocated
/dev/dm-16 1.31TB 8.00MB 28.00GB x2 4.00MB 8.00MB x2 0.00
====== ======== =========== ====== =========== ===========
Total 1.31TB 8.00MB 28.00GB 4.00MB 8.00MB 0.00
Used 1.31TB 0.00 5.65GB 0.00 152.00KB
However how your solution will became when RAID5/RAID6 will arrive ? mmm
may be the solution is simpler: the "x2" factor is applied only to DUP
profile. The other profiles span different disks.
As another option, we can add a field/line which reports the RAID factor:
Metadata,DUP: Size: 1.75GB, Used: 627.84MB, Raid factor: 2x
/dev/dm-0 3.50GB
Data Metadata Metadata System System
Single Single DUP Single DUP Unallocated
/dev/dm-16 1.31TB 8.00MB 56.00GB 4.00MB 16.00MB 0.00
====== ======== ======== ====== ======== ===========
Raid factor - - x2 - x2 -
Total 1.31TB 8.00MB 28.00GB 4.00MB 8.00MB 0.00
Used 1.31TB 0.00 5.65GB 0.00 152.00KB
>
> Also, I don't know if you could use libblkid, but it finds more
> descriptive names than dm-NN (thanks to some smart sorting logic).
I don't think that it would be impossible to use libblkid, however it
would be difficult to find spaces for longer device name
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
gpg @keyserver.linux.it: Goffredo Baroncelli (kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5
next prev parent reply other threads:[~2012-11-02 19:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 10:15 [PATCH][BTRFS-PROGS] Enhance btrfs fi df Goffredo Baroncelli
2012-11-02 10:15 ` [PATCH 1/8] Enhance the command btrfs filesystem df Goffredo Baroncelli
2012-11-02 10:15 ` [PATCH 2/8] Create the man page entry for the command btrfs fi df Goffredo Baroncelli
2012-11-02 10:15 ` [PATCH 3/8] Move open_file_or_dir() in utils.c Goffredo Baroncelli
2012-11-02 10:15 ` [PATCH 4/8] Move scrub_fs_info() and scrub_dev_info() " Goffredo Baroncelli
2012-11-02 10:15 ` [PATCH 5/8] Add command btrfs filesystem disk-usage Goffredo Baroncelli
2012-11-02 10:15 ` [PATCH 6/8] Create entry in man page for " Goffredo Baroncelli
2012-11-02 10:15 ` [PATCH 7/8] Add btrfs device disk-usage command Goffredo Baroncelli
2012-11-02 10:15 ` [PATCH 8/8] Create a new entry in btrfs man page for btrfs device disk-usage Goffredo Baroncelli
2012-11-02 11:18 ` [PATCH][BTRFS-PROGS] Enhance btrfs fi df Martin Steigerwald
2012-11-02 12:02 ` Goffredo Baroncelli
2012-11-02 19:05 ` Gabriel
2012-11-02 19:31 ` Goffredo Baroncelli [this message]
2012-11-02 20:40 ` Gabriel
2012-11-02 21:46 ` Michael Kjörling
2012-11-02 23:34 ` Gabriel
2012-11-02 22:06 ` Hugo Mills
2012-11-02 23:23 ` Gabriel
2012-11-02 23:44 ` Hugo Mills
2012-11-03 0:14 ` Gabriel
2012-11-03 12:28 ` Goffredo Baroncelli
2012-11-03 12:35 ` Goffredo Baroncelli
2012-11-03 22:04 ` cwillu
2012-11-03 12:11 ` Goffredo Baroncelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50941FAC.1010803@gmail.com \
--to=kreijack@gmail.com \
--cc=g2p.code@gmail.com \
--cc=kreijack@inwind.it \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).