From: Anand Jain <Anand.Jain@oracle.com>
To: "Fajar A. Nugraha" <list@fajar.net>
Cc: Hugo Mills <hugo@carfax.org.uk>, cwillu <cwillu@cwillu.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [Request for review] [RFC] Add label support for snapshots and subvols
Date: Mon, 05 Nov 2012 15:24:48 +0800 [thread overview]
Message-ID: <509769C0.2040508@oracle.com> (raw)
In-Reply-To: <CAG1y0scEreHgQwFBCABRwbF1_mQaibgPwLBKUOLJD7kV2HL7JA@mail.gmail.com>
Thanks for all the comments and inputs.
feature xattr btrfs-kernel-way
[1] No Yes
[2] No Yes
[3] Yes No
[1]. Ability to read subvol label without mount
[2]. Full-ability to log and track the property
when it is modified
[3]. risk-free patch ?
Any comments on why not the btrfs-kernel-way and a review
of the patch ?
Thanks -Anand
On 11/02/2012 06:49 AM, Fajar A. Nugraha wrote:
> On Fri, Nov 2, 2012 at 5:32 AM, Hugo Mills <hugo@carfax.org.uk> wrote:
>> On Fri, Nov 02, 2012 at 05:28:01AM +0700, Fajar A. Nugraha wrote:
>>> On Fri, Nov 2, 2012 at 5:16 AM, cwillu <cwillu@cwillu.com> wrote:
>>>>> btrfs fi label -t /btrfs/snap1-sv1
>>>>> Prod-DB-sand-box-testing
>>>>
>>>> Why is this better than:
>>>>
>>>> # btrfs su snap /btrfs/Prod-DB /btrfs/Prod-DB-sand-box-testing
>>>> # mv /btrfs/Prod-DB-sand-box-testing /btrfs/Prod-DB-production-test
>>>> # ls /btrfs/
>>>> Prod-DB Prod-DB-production-test
>>>
>>>
>>> ... because it would mean possibilty to decouple subvol name from
>>> whatever-data-you-need (in this case, a label).
>>>
>>> My request, though, is to just implement properties, and USER
>>> properties, like what we have in zfs. This seems to be a cleaner,
>>> saner approach. For example, this is on Ubutu + zfsonlinux:
>>>
>>> # zfs create rpool/u
>>> # zfs set user:label="Some test filesystem" rpool/u
>>> # zfs get creation,user:label rpool/u
>>> NAME PROPERTY VALUE SOURCE
>>> rpool/u creation Fri Nov 2 5:24 2012 -
>>> rpool/u user:label Some test filesystem local
>>
>> Don't we already have an equivalent to that with user xattrs?
>>
>> Hugo.
>
>
> Anand did say one way to implement the label is by using attr, so +1
> from me for that approach.
>
next prev parent reply other threads:[~2012-11-05 7:25 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 10:46 [Request for review] [RFC] Add label support for snapshots and subvols Anand jain
2012-11-01 10:46 ` [PATCH 1/2] Btrfs-progs: move open_file_or_dir() to utils.c Anand jain
2012-11-01 10:46 ` [PATCH 2/2] Btrfs-progs: add feature to label subvol and snapshot Anand jain
2012-11-01 10:46 ` [PATCH] Btrfs: add label to snapshot and subvol Anand jain
2012-11-05 7:39 ` Jan Schmidt
2012-11-16 5:15 ` Anand Jain
2012-11-01 22:16 ` [Request for review] [RFC] Add label support for snapshots and subvols cwillu
2012-11-01 22:28 ` Fajar A. Nugraha
2012-11-01 22:32 ` Hugo Mills
2012-11-01 22:49 ` Fajar A. Nugraha
2012-11-05 7:24 ` Anand Jain [this message]
2012-11-05 23:22 ` David Sterba
2012-11-01 23:04 ` Goffredo Baroncelli
2012-11-16 4:52 ` [Request for review v2] " Anand jain
2012-11-16 4:52 ` [PATCH 1/3] Btrfs-progs: move open_file_or_dir() to utils.c Anand jain
2012-11-16 4:52 ` [PATCH v2] Btrfs: add label to snapshot and subvol Anand jain
2012-11-16 6:33 ` Miao Xie
2012-11-27 18:26 ` Anand Jain
2012-11-16 4:52 ` [PATCH 2/3] Btrfs-progs: add feature to label subvol and snapshot Anand jain
2012-11-16 4:52 ` [PATCH 3/3] Btrfs-progs: cmd option to show or set the subvol label Anand jain
2012-11-27 18:29 ` [Request for review v3] [RFC] Add label support for snapshots and subvols Anand jain
2012-11-27 18:29 ` [PATCH v3] Btrfs: add label to snapshot and subvol Anand jain
2012-11-28 3:05 ` Miao Xie
2012-11-28 10:02 ` Anand Jain
2012-11-28 10:25 ` Miao Xie
2012-11-28 12:17 ` Anand Jain
2012-11-28 12:15 ` Anand jain
2012-11-27 18:29 ` [PATCH 1/3] Btrfs-progs: move open_file_or_dir() to utils.c Anand jain
2012-11-27 18:29 ` [PATCH 2/3] Btrfs-progs: add feature to label subvol and snapshot Anand jain
2012-11-27 18:29 ` [PATCH 3/3] Btrfs-progs: cmd option to show or set the subvol label Anand jain
2012-11-30 15:47 ` [PATCH 0/3] Add subvol and snapshot attribute label Anand jain
2012-11-30 15:48 ` [PATCH 1/3] Btrfs-progs: move open_file_or_dir() to utils.c Anand jain
2012-11-30 15:48 ` [PATCH 2/3] Btrfs-progs: add attribute label for subvol and snapshot Anand jain
2012-11-30 15:48 ` [PATCH 3/3] Btrfs-progs: cmd option to show or set the subvol label Anand jain
2013-02-25 5:31 ` [PATCH 0/2 v4] Btrfs-progs: Add support for " Anand Jain
2013-02-25 5:31 ` [PATCH 1/2 v4] Btrfs-progs: add feature to label subvol and snapshot Anand Jain
2013-02-25 5:31 ` [PATCH 2/2 v4] Btrfs-progs: cmd option to show or set the subvol label Anand Jain
2013-02-25 5:31 ` [PATCH v4] Btrfs: Add support for " Anand Jain
2013-02-25 5:31 ` [PATCH v4] Btrfs: ability to add label to snapshot and subvol Anand Jain
2013-02-25 20:45 ` Hugo Mills
2013-03-01 10:36 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509769C0.2040508@oracle.com \
--to=anand.jain@oracle.com \
--cc=cwillu@cwillu.com \
--cc=hugo@carfax.org.uk \
--cc=linux-btrfs@vger.kernel.org \
--cc=list@fajar.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).