linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miao Xie <miaox@cn.fujitsu.com>
To: Chris Samuel <chris@csamuel.org>
Cc: Linux Btrfs <linux-btrfs@vger.kernel.org>,
	Arne Jansen <sensille@gmx.net>,
	wangshilong <wangsl-fnst@cn.fujitsu.com>
Subject: Re: [RFC PATCH] Btrfs-progs: disable qgroupid 0 for quota_tree
Date: Mon, 12 Nov 2012 10:21:12 +0800	[thread overview]
Message-ID: <50A05D18.7080503@cn.fujitsu.com> (raw)
In-Reply-To: <509C4160.2050900@csamuel.org>

On fri, 09 Nov 2012 10:33:52 +1100, Chris Samuel wrote:
> On 08/11/12 20:55, Miao Xie wrote:
> 
>> In kernel, qgroupid 0 is a special number when we run the quota group
>> limit command.
>>
>> So, we should not be able to create a quota group whose id is 0,
>> otherwise the kernel can't deal with it. Fix it.
> 
> This is probably a stupid question - but if its not meant to be possible
> to create such a thing shouldn't this be fixed in the kernel (as well as
> here) to reject attempts from user space to create it?
> 
> Otherwise it's possible for a non-aware program (or a user who is
> playing) to still create it.

Right. It also should be fixed in the kernel side, the patch is coming.

But since we know which number is valid or not, it is better that we also check
the arguments in the user tool before they are passed into the kernel. So, we
can avoid trapping into the kernel, which will waste time, and output the error
information as soon as possible.

Thanks
Miao

  reply	other threads:[~2012-11-12  2:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <509B8053.3080509@cn.fujitsu.com>
2012-11-08  9:55 ` [RFC PATCH] Btrfs-progs: disable qgroupid 0 for quota_tree Miao Xie
2012-11-08 23:33   ` Chris Samuel
2012-11-12  2:21     ` Miao Xie [this message]
2012-11-12  6:25       ` Jan Schmidt
2012-11-12  7:08         ` Miao Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A05D18.7080503@cn.fujitsu.com \
    --to=miaox@cn.fujitsu.com \
    --cc=chris@csamuel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=sensille@gmx.net \
    --cc=wangsl-fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).