From: Miao Xie <miaox@cn.fujitsu.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: linux-btrfs@vger.kernel.org, anand.jain@oracle.com
Subject: Re: [PATCH V4 2/2] Btrfs: Add a new ioctl to change the label of a mounted filesystem
Date: Wed, 12 Dec 2012 11:03:37 +0800 [thread overview]
Message-ID: <50C7F409.3000902@cn.fujitsu.com> (raw)
In-Reply-To: <50C7CE44.3010405@oracle.com>
Hi, Liu
On wed, 12 Dec 2012 08:22:28 +0800, Jeff Liu wrote:
> Add a new ioctl BTRFS_FS_SETLABEL to change the label of a mounted filesystem.
>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>
> ---
> fs/btrfs/ioctl.c | 14 ++++++++++++++
> fs/btrfs/ioctl.h | 2 ++
> 2 files changed, 16 insertions(+)
>
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 8fcf9a5..b0a5e17 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -3699,6 +3699,18 @@ out:
> return ret;
> }
>
> +static int btrfs_ioctl_get_fslabel(struct btrfs_root *root, void __user *arg)
> +{
> + const char *label = root->fs_info->super_copy->label;
> + int ret;
> +
> + mutex_lock(&root->fs_info->volume_mutex);
> + ret = copy_to_user(arg, label, strlen(label));
> + mutex_unlock(&root->fs_info->volume_mutex);
> +
> + return ret ? -EFAULT : 0;
> +}
You sent out a wrong patch.
Thanks
Miao
> +
> long btrfs_ioctl(struct file *file, unsigned int
> cmd, unsigned long arg)
> {
> @@ -3797,6 +3809,8 @@ long btrfs_ioctl(struct file *file, unsigned int
> return btrfs_ioctl_qgroup_create(root, argp);
> case BTRFS_IOC_QGROUP_LIMIT:
> return btrfs_ioctl_qgroup_limit(root, argp);
> + case BTRFS_IOC_GET_FSLABEL:
> + return btrfs_ioctl_get_fslabel(root, argp);
> }
>
> return -ENOTTY;
> diff --git a/fs/btrfs/ioctl.h b/fs/btrfs/ioctl.h
> index 731e287..98f896f 100644
> --- a/fs/btrfs/ioctl.h
> +++ b/fs/btrfs/ioctl.h
> @@ -453,4 +453,6 @@ struct btrfs_ioctl_send_args {
> struct btrfs_ioctl_qgroup_limit_args)
> #define BTRFS_IOC_GET_DEV_STATS _IOWR(BTRFS_IOCTL_MAGIC, 52, \
> struct btrfs_ioctl_get_dev_stats)
> +#define BTRFS_IOC_GET_FSLABEL _IOR(BTRFS_IOCTL_MAGIC, 53, \
> + char[BTRFS_LABEL_SIZE])
> #endif
>
next prev parent reply other threads:[~2012-12-12 3:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 0:22 [RFC PATCH V4 0/2] Btrfs: get/set mounted filesystem label support Jeff Liu
2012-12-12 0:22 ` [PATCH V4 1/2] Btrfs: Add a new ioctl to get the label of a mounted filesystem Jeff Liu
2012-12-12 0:22 ` [PATCH V4 2/2] Btrfs: Add a new ioctl to change " Jeff Liu
2012-12-12 3:03 ` Miao Xie [this message]
2012-12-12 3:17 ` Jeff Liu
2012-12-12 0:30 ` [PATCH v4 1/3] Btrfs-progs: get " Jeff Liu
2012-12-12 0:30 ` [PATCH v4 2/3] Btrfs-progs: change " Jeff Liu
2012-12-12 0:30 ` [PATCH v4 3/3] Btrfs-progs: fix cmd_label_usage to reflect this change Jeff Liu
2012-12-12 3:22 ` [RESEND PATCH V4 1/2] Btrfs: Add a new ioctl to get the label of a mounted filesystem Jeff Liu
2012-12-12 3:50 ` Miao Xie
2012-12-12 4:01 ` Jeff Liu
2012-12-12 3:23 ` [RESEND PATCH V4 2/2] Btrfs: Add a new ioctl to change " Jeff Liu
2012-12-12 4:15 ` Miao Xie
2012-12-17 7:27 ` Jeff Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C7F409.3000902@cn.fujitsu.com \
--to=miaox@cn.fujitsu.com \
--cc=anand.jain@oracle.com \
--cc=jeff.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).